* [PATCH] kvm: remove unnecessary PageReserved check
@ 2019-08-05 9:21 Paolo Bonzini
2019-08-05 15:05 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2019-08-05 9:21 UTC (permalink / raw)
To: linux-kernel, kvm
The same check is already done in kvm_is_reserved_pfn.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
virt/kvm/kvm_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 416969d9fefe..c5f1186f4b60 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1855,8 +1855,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn)
if (!kvm_is_reserved_pfn(pfn)) {
struct page *page = pfn_to_page(pfn);
- if (!PageReserved(page))
- SetPageDirty(page);
+ SetPageDirty(page);
}
}
EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: remove unnecessary PageReserved check
2019-08-05 9:21 [PATCH] kvm: remove unnecessary PageReserved check Paolo Bonzini
@ 2019-08-05 15:05 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2019-08-05 15:05 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, kvm
On Mon, Aug 05, 2019 at 11:21:42AM +0200, Paolo Bonzini wrote:
> The same check is already done in kvm_is_reserved_pfn.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
This patch was effectively submitted in Nov 2018, but was buried at the
end of a DAX series. https://patchwork.kernel.org/patch/10886265/
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> virt/kvm/kvm_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 416969d9fefe..c5f1186f4b60 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1855,8 +1855,7 @@ void kvm_set_pfn_dirty(kvm_pfn_t pfn)
> if (!kvm_is_reserved_pfn(pfn)) {
> struct page *page = pfn_to_page(pfn);
>
> - if (!PageReserved(page))
> - SetPageDirty(page);
> + SetPageDirty(page);
> }
> }
> EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-05 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 9:21 [PATCH] kvm: remove unnecessary PageReserved check Paolo Bonzini
2019-08-05 15:05 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).