From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: Chuhong Yuan <hslester96@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] iio: tsl2772: Use devm_add_action_or_reset
Date: Mon, 5 Aug 2019 16:25:30 +0100 [thread overview]
Message-ID: <20190805162530.4c24df1c@archlinux> (raw)
In-Reply-To: <20190801093731.GC27653@onstation.org>
On Thu, 1 Aug 2019 05:37:31 -0400
Brian Masney <masneyb@onstation.org> wrote:
> On Thu, Aug 01, 2019 at 05:33:47AM -0400, Brian Masney wrote:
> > On Thu, Aug 01, 2019 at 03:35:57PM +0800, Chuhong Yuan wrote:
> > > Use devm_add_action_or_reset to remove the call to
> > > tsl2772_disable_regulators_action to simplify the error path.
> > >
> > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> >
> > For the whole series:
> >
> > Reviewed-by: Brian Masney <masneyb@onstation.org>
>
> Oops, I forgot to add this as well:
>
> Tested-by: Brian Masney <masneyb@onstation.org>
>
> I tested this on a Nexus 5 phone.
>
> Brian
>
Applied to the togreg branch of iio.git and pushed out as testing.
Now the fact we have a fix in the middle of this series is
a bit unfortunate as it'll mean we need an explicit backport to
take that for stable.
Oh well, if anyone wants it up to them to do the work ;)
Thanks,
Jonathan
>
> >
> > I forgot to mention this before, but next time please use a cover letter
> > if you're sending more than one patch: git format-patch --cover-letter.
> >
> > Brian
> >
> >
> > > ---
> > > Changes in v4:
> > > - Split v3 into three patches.
> > > - Revise description to make it more precise.
> > >
> > > drivers/iio/light/tsl2772.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
> > > index 83cece921843..29cfd8ae2700 100644
> > > --- a/drivers/iio/light/tsl2772.c
> > > +++ b/drivers/iio/light/tsl2772.c
> > > @@ -1807,10 +1807,10 @@ static int tsl2772_probe(struct i2c_client *clientp,
> > > return PTR_ERR(chip->vdd_supply);
> > > }
> > >
> > > - ret = devm_add_action(&clientp->dev, tsl2772_disable_regulators_action,
> > > - chip);
> > > + ret = devm_add_action_or_reset(&clientp->dev,
> > > + tsl2772_disable_regulators_action,
> > > + chip);
> > > if (ret < 0) {
> > > - tsl2772_disable_regulators_action(chip);
> > > dev_err(&clientp->dev, "Failed to setup regulator cleanup action %d\n",
> > > ret);
> > > return ret;
> > > --
> > > 2.20.1
prev parent reply other threads:[~2019-08-05 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 7:35 [PATCH v4 1/4] iio: tsl2772: Use devm_add_action_or_reset Chuhong Yuan
2019-08-01 9:33 ` Brian Masney
2019-08-01 9:37 ` Brian Masney
2019-08-05 15:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805162530.4c24df1c@archlinux \
--to=jic23@kernel.org \
--cc=hslester96@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).