From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiangfeng Xiao <xiaojiangfeng@huawei.com>
Cc: <davem@davemloft.net>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <leeyou.li@huawei.com>,
<xiaowei774@huawei.com>, <nixiaoming@huawei.com>
Subject: Re: [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant
Date: Mon, 5 Aug 2019 20:05:55 -0700 [thread overview]
Message-ID: <20190805200555.5a171567@cakuba.netronome.com> (raw)
In-Reply-To: <c150d41b-6f0e-ad49-e8c2-00896fc9cbe4@huawei.com>
On Tue, 6 Aug 2019 10:00:52 +0800, Jiangfeng Xiao wrote:
> If hip04_tx_reclaim is interrupted while it is running, and then
> __irq_svc->gic_handle_irq->hip04_mac_interrupt->__napi_schedule->hip04_rx_poll->hip04_tx_reclaim
Ah right, obviously you can't do stuff after napi_complete_done(),
that makes sense.
Series looks reasonable.
next prev parent reply other threads:[~2019-08-06 3:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 12:31 [PATCH v1 0/3] net: hisilicon: Fix a few problems with hip04_eth Jiangfeng Xiao
2019-08-03 12:31 ` [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant Jiangfeng Xiao
2019-08-06 0:46 ` Jakub Kicinski
2019-08-06 2:00 ` Jiangfeng Xiao
2019-08-06 3:05 ` Jakub Kicinski [this message]
2019-08-03 12:31 ` [PATCH v1 2/3] net: hisilicon: fix hip04-xmit never return TX_BUSY Jiangfeng Xiao
2019-08-03 12:31 ` [PATCH v1 3/3] net: hisilicon: Fix dma_map_single failed on arm64 Jiangfeng Xiao
2019-08-06 21:15 ` [PATCH v1 0/3] net: hisilicon: Fix a few problems with hip04_eth David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805200555.5a171567@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=leeyou.li@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=salil.mehta@huawei.com \
--cc=xiaojiangfeng@huawei.com \
--cc=xiaowei774@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).