From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: agross@kernel.org, robdclark@gmail.com, sean@poorly.run,
robh+dt@kernel.org, airlied@linux.ie, daniel@ffwll.ch,
mark.rutland@arm.com, jonathan@marek.ca,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, jcrouse@codeaurora.org
Subject: Re: [PATCH v4 5/6] soc: qcom: add OCMEM driver
Date: Mon, 5 Aug 2019 15:41:12 -0700 [thread overview]
Message-ID: <20190805224112.GA6470@builder> (raw)
In-Reply-To: <20190803142026.9647-6-masneyb@onstation.org>
On Sat 03 Aug 07:20 PDT 2019, Brian Masney wrote:
> diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
> new file mode 100644
> index 000000000000..7c28ad3108a6
> --- /dev/null
> +++ b/drivers/soc/qcom/ocmem.c
> @@ -0,0 +1,433 @@
> +// SPDX-License-Identifier: GPL-2.0-only
[..]
> +MODULE_LICENSE("GPL");
Shouldn't this be "GPL v2"?
Apart from that I think this looks good.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
@Rob, would you like to take this series through your tree or would you
lend me an Ack on the adreno patch and I'll apply it through the qcom
tree? Feel free to add my Acked-by to the relevant patches, if needed.
Regards,
Bjorn
next prev parent reply other threads:[~2019-08-05 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 14:20 [PATCH v4 0/6] qcom: add OCMEM support Brian Masney
2019-08-03 14:20 ` [PATCH v4 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings Brian Masney
2019-08-05 15:10 ` Rob Herring
2019-08-03 14:20 ` [PATCH v4 2/6] dt-bindings: display: msm: gmu: add optional ocmem property Brian Masney
2019-08-03 14:20 ` [PATCH v4 3/6] firmware: qcom: scm: add OCMEM lock/unlock interface Brian Masney
2019-08-03 14:20 ` [PATCH v4 4/6] firmware: qcom: scm: add support to restore secure config to qcm_scm-32 Brian Masney
2019-08-03 14:20 ` [PATCH v4 5/6] soc: qcom: add OCMEM driver Brian Masney
2019-08-05 22:41 ` Bjorn Andersson [this message]
2019-08-03 14:20 ` [PATCH v4 6/6] drm/msm/gpu: add ocmem init/cleanup functions Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805224112.GA6470@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).