From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22917C433FF for ; Tue, 6 Aug 2019 01:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E841F214C6 for ; Tue, 6 Aug 2019 01:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731319AbfHFBce (ORCPT ); Mon, 5 Aug 2019 21:32:34 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:44310 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728870AbfHFBce (ORCPT ); Mon, 5 Aug 2019 21:32:34 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9B9D2F8EFE862C0A34B; Tue, 6 Aug 2019 09:32:32 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Tue, 6 Aug 2019 09:32:26 +0800 From: Mao Wenan To: , CC: , , , Subject: [PATCH net-next v4] net: can: Fix compiling warnings for two functions Date: Tue, 6 Aug 2019 09:37:01 +0800 Message-ID: <20190806013701.71159-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190805.103002.641507066504156536.davem@davemloft.net> References: <20190805.103002.641507066504156536.davem@davemloft.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are two warnings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should it be static? Fixes: 473d924d7d46 ("can: fix ioctl function removal") Signed-off-by: Mao Wenan Acked-by: Oliver Hartkopp --- v1->v2: change patch description typo error, 'warings' to 'warnings'. v2->v3: change subject of patch. v3->v4: change the alignment of two functions. net/can/bcm.c | 4 ++-- net/can/raw.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index bf1d0bbecec8..eb1d28b8c46a 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -1680,8 +1680,8 @@ static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, return size; } -int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, - unsigned long arg) +static int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, + unsigned long arg) { /* no ioctls for socket layer -> hand it down to NIC layer */ return -ENOIOCTLCMD; diff --git a/net/can/raw.c b/net/can/raw.c index da386f1fa815..a30aaecd9327 100644 --- a/net/can/raw.c +++ b/net/can/raw.c @@ -837,8 +837,8 @@ static int raw_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, return size; } -int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, - unsigned long arg) +static int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, + unsigned long arg) { /* no ioctls for socket layer -> hand it down to NIC layer */ return -ENOIOCTLCMD; -- 2.20.1