From: Luis Araneda <luaraneda@gmail.com>
To: linux@armlinux.org.uk, michal.simek@xilinx.com
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Luis Araneda <luaraneda@gmail.com>
Subject: [PATCH 2/2] ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up
Date: Mon, 5 Aug 2019 23:07:18 -0400 [thread overview]
Message-ID: <20190806030718.29048-3-luaraneda@gmail.com> (raw)
In-Reply-To: <20190806030718.29048-1-luaraneda@gmail.com>
This fixes a kernel panic (read overflow) on memcpy when
FORTIFY_SOURCE is enabled.
The computed size of memcpy args are:
- p_size (dst): 4294967295 = (size_t) -1
- q_size (src): 1
- size (len): 8
Additionally, the memory is marked as __iomem, so one of
the memcpy_* functions should be used for read/write
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
---
arch/arm/mach-zynq/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c
index 38728badabd4..a10085be9073 100644
--- a/arch/arm/mach-zynq/platsmp.c
+++ b/arch/arm/mach-zynq/platsmp.c
@@ -57,7 +57,7 @@ int zynq_cpun_start(u32 address, int cpu)
* 0x4: Jump by mov instruction
* 0x8: Jumping address
*/
- memcpy((__force void *)zero, &zynq_secondary_trampoline,
+ memcpy_toio(zero, &zynq_secondary_trampoline,
trampoline_size);
writel(address, zero + trampoline_size);
--
2.22.0
next prev parent reply other threads:[~2019-08-06 3:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 3:07 [PATCH 0/2] ARM: zynq: smp improvements Luis Araneda
2019-08-06 3:07 ` [PATCH 1/2] ARM: zynq: support smp in thumb mode Luis Araneda
2019-08-06 5:17 ` Greg KH
2019-08-06 6:39 ` Michal Simek
2019-08-06 12:40 ` Luis Araneda
2019-08-08 9:18 ` Michal Simek
2019-08-06 3:07 ` Luis Araneda [this message]
2019-08-06 5:17 ` [PATCH 2/2] ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up Greg KH
2019-08-06 6:41 ` Michal Simek
2019-08-06 12:49 ` Luis Araneda
2019-08-08 9:19 ` Michal Simek
2019-08-06 5:17 ` [PATCH 0/2] ARM: zynq: smp improvements Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806030718.29048-3-luaraneda@gmail.com \
--to=luaraneda@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).