From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Jim Mattson" <jmattson@google.com>,
"Sean Christopherson" <sean.j.christopherson@intel.com>
Subject: [PATCH v2 0/5] x86: KVM: svm: get rid of hardcoded instructions lengths
Date: Tue, 6 Aug 2019 08:01:45 +0200 [thread overview]
Message-ID: <20190806060150.32360-1-vkuznets@redhat.com> (raw)
Changes since v1:
- Clear interrupt shadow in x86_emulate_instruction() instead of SVM's
skip_emulated_instruction() to generalize the fix [Sean Christopherson]
Original description:
Jim rightfully complains that hardcoding instuctions lengths is not always
correct: additional (redundant) prefixes can be used. Luckily, the ugliness
is mostly harmless: modern AMD CPUs support NRIP_SAVE feature but I'd like
to clean things up and sacrifice speed in favor of correctness.
Vitaly Kuznetsov (5):
x86: KVM: svm: don't pretend to advance RIP in case
wrmsr_interception() results in #GP
x86: KVM: svm: avoid flooding logs when skip_emulated_instruction()
fails
x86: KVM: clear interrupt shadow on EMULTYPE_SKIP
x86: KVM: add xsetbv to the emulator
x86: KVM: svm: remove hardcoded instruction length from intercepts
arch/x86/include/asm/kvm_emulate.h | 3 ++-
arch/x86/kvm/emulate.c | 23 ++++++++++++++++++++++-
arch/x86/kvm/svm.c | 19 +++++--------------
arch/x86/kvm/x86.c | 7 +++++++
4 files changed, 36 insertions(+), 16 deletions(-)
--
2.20.1
next reply other threads:[~2019-08-06 6:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 6:01 Vitaly Kuznetsov [this message]
2019-08-06 6:01 ` [PATCH v2 1/5] x86: KVM: svm: don't pretend to advance RIP in case wrmsr_interception() results in #GP Vitaly Kuznetsov
2019-08-06 15:29 ` Sean Christopherson
2019-08-06 6:01 ` [PATCH v2 2/5] x86: KVM: svm: avoid flooding logs when skip_emulated_instruction() fails Vitaly Kuznetsov
2019-08-06 15:40 ` Sean Christopherson
2019-08-07 11:17 ` Vitaly Kuznetsov
2019-08-06 6:01 ` [PATCH v2 3/5] x86: KVM: clear interrupt shadow on EMULTYPE_SKIP Vitaly Kuznetsov
2019-08-06 15:45 ` Sean Christopherson
2019-08-06 6:01 ` [PATCH v2 4/5] x86: KVM: add xsetbv to the emulator Vitaly Kuznetsov
2019-08-06 6:01 ` [PATCH v2 5/5] x86: KVM: svm: remove hardcoded instruction length from intercepts Vitaly Kuznetsov
2019-08-06 16:11 ` Sean Christopherson
2019-08-07 11:14 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806060150.32360-1-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).