linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] fix kernel panic due to use uninitialized struct pages
@ 2019-07-25  2:31 Toshiki Fukasawa
  2019-07-25  2:31 ` [PATCH 1/2] /proc/kpageflags: prevent an integer overflow in stable_page_flags() Toshiki Fukasawa
  2019-07-25  2:31 ` [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages Toshiki Fukasawa
  0 siblings, 2 replies; 13+ messages in thread
From: Toshiki Fukasawa @ 2019-07-25  2:31 UTC (permalink / raw)
  To: linux-mm
  Cc: linux-kernel, akpm, mhocko, dan.j.williams, adobriyan, hch,
	Naoya Horiguchi, Junichi Nomura, Toshiki Fukasawa

A kernel panic was observed during reading /proc/kpageflags for
first few pfns allocated by pmem namespace:

BUG: unable to handle page fault for address: fffffffffffffffe
[  114.495280] #PF: supervisor read access in kernel mode
[  114.495738] #PF: error_code(0x0000) - not-present page
[  114.496203] PGD 17120e067 P4D 17120e067 PUD 171210067 PMD 0
[  114.496713] Oops: 0000 [#1] SMP PTI
[  114.497037] CPU: 9 PID: 1202 Comm: page-types Not tainted 5.3.0-rc1 #1
[  114.497621] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.11.0-0-g63451fca13-prebuilt.qemu-project.org 04/01/2014
[  114.498706] RIP: 0010:stable_page_flags+0x27/0x3f0
[  114.499142] Code: 82 66 90 66 66 66 66 90 48 85 ff 0f 84 d1 03 00 00 41 54 55 48 89 fd 53 48 8b 57 08 48 8b 1f 48 8d 42 ff 83 e2 01 48 0f 44 c7 <48> 8b 00 f6 c4 02 0f 84 57 03 00 00 45 31 e4 48 8b 55 08 48 89 ef
[  114.500788] RSP: 0018:ffffa5e601a0fe60 EFLAGS: 00010202
[  114.501373] RAX: fffffffffffffffe RBX: ffffffffffffffff RCX: 0000000000000000
[  114.502009] RDX: 0000000000000001 RSI: 00007ffca13a7310 RDI: ffffd07489000000
[  114.502637] RBP: ffffd07489000000 R08: 0000000000000001 R09: 0000000000000000
[  114.503270] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000240000
[  114.503896] R13: 0000000000080000 R14: 00007ffca13a7310 R15: ffffa5e601a0ff08
[  114.504530] FS:  00007f0266c7f540(0000) GS:ffff962dbbac0000(0000) knlGS:0000000000000000
[  114.505245] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  114.505754] CR2: fffffffffffffffe CR3: 000000023a204000 CR4: 00000000000006e0
[  114.506401] Call Trace:
[  114.506660]  kpageflags_read+0xb1/0x130
[  114.507051]  proc_reg_read+0x39/0x60
[  114.507387]  vfs_read+0x8a/0x140
[  114.507686]  ksys_pread64+0x61/0xa0
[  114.508021]  do_syscall_64+0x5f/0x1a0
[  114.508372]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  114.508844] RIP: 0033:0x7f0266ba426b

Earlier approach to fix this was discussed here:
https://marc.info/?l=linux-mm&m=152964770000672&w=2

This patchset is another approach to fix it and also provide
a fix for potential future bugs discovered in the process.

Toshiki Fukasawa (2):
  /proc/kpageflags: prevent an integer overflow in stable_page_flags()
  /proc/kpageflags: do not use uninitialized struct pages

 fs/proc/page.c           | 40 +++++++++++++++++++++-------------------
 include/linux/memremap.h |  6 ++++++
 kernel/memremap.c        | 20 ++++++++++++++++++++
 3 files changed, 47 insertions(+), 19 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-08-07 13:17 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25  2:31 [PATCH 0/2] fix kernel panic due to use uninitialized struct pages Toshiki Fukasawa
2019-07-25  2:31 ` [PATCH 1/2] /proc/kpageflags: prevent an integer overflow in stable_page_flags() Toshiki Fukasawa
2019-07-25  6:45   ` Alexey Dobriyan
2019-07-25  2:31 ` [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages Toshiki Fukasawa
2019-07-25  9:03   ` Michal Hocko
2019-07-26  6:25     ` Toshiki Fukasawa
2019-07-26  7:06       ` Michal Hocko
2019-08-05  5:12         ` Toshiki Fukasawa
2019-08-06  3:27           ` Dan Williams
2019-08-06  6:46             ` Michal Hocko
2019-08-06 16:15               ` Dan Williams
2019-08-07 13:17                 ` Michal Hocko
2019-08-06  3:34   ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).