From: Michal Hocko <mhocko@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH RFC] mm/memcontrol: reclaim severe usage over high limit in get_user_pages loop
Date: Tue, 6 Aug 2019 09:36:24 +0200 [thread overview]
Message-ID: <20190806073624.GD11812@dhcp22.suse.cz> (raw)
In-Reply-To: <c6b2c864-985a-2565-95e7-3af9e3e015f8@yandex-team.ru>
On Tue 06-08-19 10:19:49, Konstantin Khlebnikov wrote:
> On 8/6/19 10:07 AM, Michal Hocko wrote:
> > On Fri 02-08-19 13:44:38, Michal Hocko wrote:
> > [...]
> > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > > > > index ba9138a4a1de..53a35c526e43 100644
> > > > > --- a/mm/memcontrol.c
> > > > > +++ b/mm/memcontrol.c
> > > > > @@ -2429,8 +2429,12 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > > > > schedule_work(&memcg->high_work);
> > > > > break;
> > > > > }
> > > > > - current->memcg_nr_pages_over_high += batch;
> > > > > - set_notify_resume(current);
> > > > > + if (gfpflags_allow_blocking(gfp_mask)) {
> > > > > + reclaim_high(memcg, nr_pages, GFP_KERNEL);
> > >
> > > ups, this should be s@GFP_KERNEL@gfp_mask@
> > >
> > > > > + } else {
> > > > > + current->memcg_nr_pages_over_high += batch;
> > > > > + set_notify_resume(current);
> > > > > + }
> > > > > break;
> > > > > }
> > > > > } while ((memcg = parent_mem_cgroup(memcg)));
> > > > >
> >
> > Should I send an official patch for this?
> >
>
> I prefer to keep it as is while we have no better solution.
Fine with me.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-08-06 7:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 12:29 [PATCH RFC] mm/memcontrol: reclaim severe usage over high limit in get_user_pages loop Konstantin Khlebnikov
2019-07-29 9:17 ` Michal Hocko
2019-07-29 9:40 ` Konstantin Khlebnikov
2019-07-29 10:33 ` Michal Hocko
2019-07-29 11:24 ` Konstantin Khlebnikov
2019-07-29 17:28 ` Yang Shi
2019-07-29 18:48 ` Michal Hocko
2019-08-01 21:00 ` Yang Shi
2019-08-02 9:35 ` Michal Hocko
2019-08-02 18:56 ` Yang Shi
2019-08-05 14:32 ` Michal Hocko
2019-08-05 19:24 ` Shakeel Butt
2019-08-06 3:28 ` Yang Shi
2019-08-06 7:05 ` Michal Hocko
2019-07-29 15:49 ` Johannes Weiner
2019-07-29 18:55 ` Michal Hocko
2019-08-02 9:40 ` Michal Hocko
2019-08-02 10:01 ` Konstantin Khlebnikov
2019-08-02 11:44 ` Michal Hocko
2019-08-06 7:07 ` Michal Hocko
2019-08-06 7:19 ` Konstantin Khlebnikov
2019-08-06 7:36 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806073624.GD11812@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).