From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Tom Stonecypher <thomas.edwardx.stonecypher@intel.com>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>
Subject: [PATCH 3/3] kbuild: show hint if subdir-y/m is used to visit module Makefile
Date: Tue, 6 Aug 2019 19:03:23 +0900 [thread overview]
Message-ID: <20190806100323.22919-3-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20190806100323.22919-1-yamada.masahiro@socionext.com>
Since commit ff9b45c55b26 ("kbuild: modpost: read modules.order instead
of $(MODVERDIR)/*.mod"), a module is no longer built in the following
pattern:
[Makefile]
subdir-y := some-module
[some-module/Makefile]
obj-m := some-module.o
You cannot write Makefile this way in upstream because modules.order is
not correctly generated. subdir-y is used to descend to a sub-directory
that builds tools, device trees, etc.
For external modules, the modules order does not matter. So, the
Makefile above was known to work.
I believe the Makefile should be re-written as follows:
[Makefile]
obj-m := some-module/
[some-module/Makefile]
obj-m := some-module.o
However, people will have no idea if their Makefile suddenly stops
working. In fact, I received questions from multiple people.
Show a warning if obj-m is specified in a Makefile visited by subdir-y
or subdir-m.
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tom Stonecypher <thomas.edwardx.stonecypher@intel.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/Makefile.build | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 37a1d2cd49d4..4a26c7ed9198 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -52,6 +52,13 @@ ifndef obj
$(warning kbuild: Makefile.build is included improperly)
endif
+ifeq ($(need-modorder),)
+ifneq ($(obj-m),)
+$(warning $(patsubst %.o,'%.ko',$(obj-m)) will not be built even though obj-m is specified.)
+$(warning You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead.)
+endif
+endif
+
# ===========================================================================
ifneq ($(strip $(lib-y) $(lib-m) $(lib-)),)
--
2.17.1
next prev parent reply other threads:[~2019-08-06 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 10:03 [PATCH 1/3] kbuild: fix false-positive need-builtin Masahiro Yamada
2019-08-06 10:03 ` [PATCH 2/3] kbuild: generate modules.order only in directories visited by obj-y/m Masahiro Yamada
2019-08-06 10:03 ` Masahiro Yamada [this message]
2019-08-08 6:29 ` [PATCH 3/3] kbuild: show hint if subdir-y/m is used to visit module Makefile Masahiro Yamada
2019-08-07 15:22 ` [PATCH 1/3] kbuild: fix false-positive need-builtin Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806100323.22919-3-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=thomas.edwardx.stonecypher@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).