linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Mao Wenan <maowenan@huawei.com>,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: can: Fix compiling warning
Date: Tue, 6 Aug 2019 16:52:31 +0300	[thread overview]
Message-ID: <20190806135231.GJ1974@kadam> (raw)
In-Reply-To: <0050efdb-af9f-49b9-8d83-f574b3d46a2e@hartkopp.net>

On Fri, Aug 02, 2019 at 10:10:20AM +0200, Oliver Hartkopp wrote:
> On 02/08/2019 05.36, Mao Wenan wrote:
> > There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd
> > and raw_sock_no_ioctlcmd as static.
> > 
> > net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static?
> > net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should it be static?
> > 
> > Fixes: 473d924d7d46 ("can: fix ioctl function removal")
> > 
> > Signed-off-by: Mao Wenan <maowenan@huawei.com>
> 
> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
> 
> Thanks Mao!
> 
> Btw. what kind of compiler/make switches are you using so that I can see
> these warnings myself the next time?

These are Sparse warnings, not from GCC.

regards,
dan carpenter


  parent reply	other threads:[~2019-08-06 13:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02  3:36 [PATCH net-next] net: can: Fix compiling warning Mao Wenan
2019-08-02  8:10 ` Oliver Hartkopp
2019-08-02  8:39   ` maowenan
2019-08-06 13:52   ` Dan Carpenter [this message]
2019-08-06 16:41     ` Oliver Hartkopp
2019-08-07 10:50       ` Dan Carpenter
2019-08-12 17:19         ` Kees Cook
2019-08-13 12:48           ` Dan Carpenter
2019-08-12  5:48       ` maowenan
2019-08-12  8:11         ` Oliver Hartkopp
2019-08-02  8:59 ` Sergei Shtylyov
2019-08-05  1:13   ` maowenan
2019-08-05  1:26     ` [PATCH net-next v2] " Mao Wenan
2019-08-05 10:56       ` [v2] " Markus Elfring
2019-08-05 11:57         ` [PATCH net-next v3] net: can: Fix compiling warnings for two functions Mao Wenan
2019-08-05 17:30           ` David Miller
2019-08-06  1:37             ` [PATCH net-next v4] " Mao Wenan
2019-08-06 11:37               ` [v4] " Markus Elfring
2019-08-06 14:40                 ` [PATCH net-next v5] net: can: Fix sparse " Mao Wenan
2019-08-05  1:22 [PATCH net-next] net: can: Fix compiling warning Mao Wenan
2019-08-05  1:22 ` maowenan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190806135231.GJ1974@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maowenan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).