From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765B9C433FF for ; Tue, 6 Aug 2019 18:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462CF216F4 for ; Tue, 6 Aug 2019 18:41:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TO8OuL1B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbfHFSkv (ORCPT ); Tue, 6 Aug 2019 14:40:51 -0400 Received: from mail-vk1-f201.google.com ([209.85.221.201]:48845 "EHLO mail-vk1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfHFSks (ORCPT ); Tue, 6 Aug 2019 14:40:48 -0400 Received: by mail-vk1-f201.google.com with SMTP id x71so29362580vkd.15 for ; Tue, 06 Aug 2019 11:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=KgzH53PwLND1jLbrm/0exiWYFdiM2SzHVv8Uf5Mh6WA=; b=TO8OuL1BlbirCPPWqGBbRPnqwohgpSqYuh+mhD9Fan+N5xQ1xSkyjcwfXIqmsy4UCP 9XcJI/4gKegHjuZT9J96o6CEHzcowSFVIEEH8eLjEVCKjWtcE6XaEeaavb0XxUegiXe+ ZmzLJa6mwQpxrwLxiwrEDMxmoyNGiEeyXQ9BQ2VpoIA4LVG9HwGTXVcg74DWpEKIApEK TIB5s9aGPzn5c59x+rXxXBEIWx49BC1LVuUnpN/Nf3jbUw1qZIqz9dgxYeMnOS6c3rGg 6KpnF9tEFyWR48Xn35qMlIJaALvbd7W09HjbGGX/vD8US+B03GIHucPGf9rOIKjcKdZt lH7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=KgzH53PwLND1jLbrm/0exiWYFdiM2SzHVv8Uf5Mh6WA=; b=GfNv5YzKicfvAnduSkp07FF+nCRMijWe93A2P/mSbsotWtcuIygaShaXrncirMXyup dyBKXUO3qbAxuis4stO2vTKpqH4j30LVxAT9EgSU5CxNnp4KsGt+3wm4hJkfzCqFqzUJ kAJHNEtDEeGt8gnJXnzOuHy3JMZk4ZFd5XR+HNbXvrT2/kuB9CPLwn+hrH7nKT8Ry+/3 qhsZMAkr9w/bP0y9BqGpQ4GC54hGN32KcJV80sTmD0SN3iOgk1tf1PqkAKXxa5wEyWOD 1qdnxVmtkd4kL/tTOT/6gu+fyrCOSP7do1uyIh2IesJLJzHtv5bp80Hna1s/dDpWRJSc 3p5Q== X-Gm-Message-State: APjAAAVIegutzS2xfTPfKIuut5KWVG/kJvl0G/q2j5YkMCv2KxDw1JaO q1riTQQ6A3w0WKgs+U7h40d7uCE2Ses= X-Google-Smtp-Source: APXvYqyj/C1aMKroLXjnt52133U+mF/4/m9/pdxH6SIvZVODYB8EP6DW0aydx4KyYo0ko4Aw4zZlgx5Prrg= X-Received: by 2002:ab0:5398:: with SMTP id k24mr1923016uaa.6.1565116847615; Tue, 06 Aug 2019 11:40:47 -0700 (PDT) Date: Tue, 6 Aug 2019 11:40:06 -0700 In-Reply-To: <20190806184007.60739-1-hridya@google.com> Message-Id: <20190806184007.60739-3-hridya@google.com> Mime-Version: 1.0 References: <20190806184007.60739-1-hridya@google.com> X-Mailer: git-send-email 2.22.0.770.g0f2c4a37fd-goog Subject: [PATCH v2 2/2] binder: Validate the default binderfs device names. From: Hridya Valsaraju To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Hridya Valsaraju , Christian Brauner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. This patch adds a check in binderfs_init() to ensure the same for the default binder devices that will be created in every binderfs instance. Co-developed-by: Christian Brauner Signed-off-by: Christian Brauner Signed-off-by: Hridya Valsaraju --- drivers/android/binderfs.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index 886b4e0f482f..52c8bd361906 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -572,6 +572,18 @@ static struct file_system_type binder_fs_type = { int __init init_binderfs(void) { int ret; + const char *name; + size_t len; + + /* Verify that the default binderfs device names are valid. */ + name = binder_devices_param; + for (len = strcspn(name, ","); len > 0; len = strcspn(name, ",")) { + if (len > BINDERFS_MAX_NAME) + return -E2BIG; + name += len; + if (*name == ',') + name++; + } /* Allocate new major number for binderfs. */ ret = alloc_chrdev_region(&binderfs_dev, 0, BINDERFS_MAX_MINOR, -- 2.22.0.770.g0f2c4a37fd-goog