From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Thomas Hellström (VMware)" <thomas@shipmail.org>,
"Dave Airlie" <airlied@gmail.com>,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Jerome Glisse" <jglisse@redhat.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Steven Price" <steven.price@arm.com>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: drm pull for v5.3-rc1
Date: Tue, 6 Aug 2019 23:38:56 -0700 [thread overview]
Message-ID: <20190807063856.GB6002@infradead.org> (raw)
In-Reply-To: <CAHk-=wi7L0MDG7DY39Hx6v8jUMSq3ZCE3QTnKKirba_8KAFNyw@mail.gmail.com>
On Tue, Aug 06, 2019 at 11:50:42AM -0700, Linus Torvalds wrote:
>
> In fact, I do note that a lot of the users don't actually use the
> "void *private" argument at all - they just want the walker - and just
> pass in a NULL private pointer. So we have things like this:
>
> > + if (walk_page_range(&init_mm, va, va + size, &set_nocache_walk_ops,
> > + NULL)) {
>
> and in a perfect world we'd have arguments with default values so that
> we could skip those entirely for when people just don't need it.
>
> I'm not a huge fan of C++ because of a lot of the complexity (and some
> really bad decisions), but many of the _syntactic_ things in C++ would
> be nice to use. This one doesn't seem to be one that the gcc people
> have picked up as an extension ;(
>
> Yes, yes, we could do it with a macro, I guess.
>
> #define walk_page_range(mm, start,end, ops, ...) \
> __walk_page_range(mm, start, end, (NULL , ## __VA_ARGS__))
>
> but I'm not sure it's worthwhile.
Given that is is just a single argument I'm not to worried. A simpler
and a more complex variant seems more useful if we can skip a few
arguments IMHO.
next prev parent reply other threads:[~2019-08-07 6:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPM=9tzJQ+26n_Df1eBPG1A=tXf4xNuVEjbG3aZj-aqYQ9nnAg@mail.gmail.com>
2019-07-15 7:08 ` drm pull for v5.3-rc1 Dave Airlie
2019-07-15 12:16 ` Daniel Vetter
2019-07-15 17:37 ` Linus Torvalds
2019-07-15 18:00 ` Linus Torvalds
2019-07-15 18:29 ` Dave Airlie
2019-07-15 18:37 ` Linus Torvalds
2019-07-15 19:35 ` Thomas Hellström (VMware)
2019-07-15 20:07 ` Linus Torvalds
2019-07-15 22:17 ` Linus Torvalds
2019-08-06 7:38 ` Christoph Hellwig
2019-08-06 7:40 ` Christoph Hellwig
2019-08-06 18:50 ` Linus Torvalds
2019-08-06 19:09 ` Matthew Wilcox
2019-08-07 6:40 ` Christoph Hellwig
2019-08-07 14:15 ` Matthew Wilcox
2019-08-07 14:30 ` Steven Price
2019-08-07 14:56 ` Matthew Wilcox
2019-08-07 15:32 ` Steven Price
2019-08-07 15:55 ` Matthew Wilcox
2019-08-07 19:16 ` Linus Torvalds
2019-08-07 6:38 ` Christoph Hellwig [this message]
2019-07-15 18:27 ` Dave Airlie
[not found] ` <CAPM=9tx+CEkzmLZ-93GZmde9xzJ_rw3PJZxFu_pjZJc7KM5f-w@mail.gmail.com>
2019-07-15 12:29 ` DRM " Jason Gunthorpe
2019-07-15 13:21 ` Stephen Rothwell
2019-07-15 14:19 ` Daniel Vetter
2019-07-15 15:04 ` Jason Gunthorpe
2019-07-15 17:53 ` Daniel Vetter
2019-07-15 17:57 ` Jason Gunthorpe
2019-07-15 18:06 ` Daniel Vetter
2019-07-15 18:16 ` Linus Torvalds
2019-07-15 19:00 ` Linus Torvalds
2019-07-15 19:17 ` Jason Gunthorpe
2019-07-15 19:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807063856.GB6002@infradead.org \
--to=hch@infradead.org \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steven.price@arm.com \
--cc=thellstrom@vmware.com \
--cc=thomas@shipmail.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).