From: Firo Yang <firo.yang@suse.com>
To: Jacob Wen <jian.w.wen@oracle.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
"alexander.h.duyck@linux.intel.com"
<alexander.h.duyck@linux.intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally
Date: Wed, 7 Aug 2019 08:38:43 +0000 [thread overview]
Message-ID: <20190807083831.GA6811@linux-6qg8> (raw)
In-Reply-To: <85aaefdf-d454-1823-5840-d9e2f71ffb19@oracle.com>
The 08/07/2019 15:56, Jacob Wen wrote:
> I think the description is not correct. Consider using something like below.
Thank you for comments.
>
> In Xen environment, due to memory fragmentation ixgbe may allocate a 'DMA'
> buffer with pages that are not physically contiguous.
Actually, I didn't look into the reason why ixgbe got a DMA buffer which
was mapped to Xen-swiotlb area.
But I don't think this issue relates to phsical memory contiguity because, in
our case, one ixgbe_rx_buffer only associates at most one page.
If you take a look at the related code, you will find there are several reasons
for mapping a DMA buffer to Xen-swiotlb area:
static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
*/
if (dma_capable(dev, dev_addr, size) &&
!range_straddles_page_boundary(phys, size) &&
!xen_arch_need_swiotlb(dev, phys, dev_addr) &&
swiotlb_force != SWIOTLB_FORCE)
goto done;
// Firo
>
> A NIC doesn't support directly write such buffer. So xen-swiotlb would use
> the pages, which are physically contiguous, from the swiotlb buffer for the
> NIC.
>
> The unmap operation is used to copy the swiotlb buffer to the pages that are
> allocated by ixgbe.
>
> On 8/7/19 10:49 AM, Firo Yang wrote:
> > In Xen environment, if Xen-swiotlb is enabled, ixgbe driver
> > could possibly allocate a page, DMA memory buffer, for the first
> > fragment which is not suitable for Xen-swiotlb to do DMA operations.
> > Xen-swiotlb have to internally allocate another page for doing DMA
> > operations. It requires syncing between those two pages. However,
> > since commit f3213d932173 ("ixgbe: Update driver to make use of DMA
> > attributes in Rx path"), the unmap operation is performed with
> > DMA_ATTR_SKIP_CPU_SYNC. As a result, the sync is not performed.
> >
> > To fix this problem, always sync before possibly performing a page
> > unmap operation.
> >
> > Fixes: f3213d932173 ("ixgbe: Update driver to make use of DMA
> > attributes in Rx path")
> > Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > Signed-off-by: Firo Yang <firo.yang@suse.com>
> > ---
> >
> > Changes from v1:
> > * Imporved the patch description.
> > * Added Reviewed-by: and Fixes: as suggested by Alexander Duyck
> >
> > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > index cbaf712d6529..200de9838096 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > @@ -1825,13 +1825,7 @@ static void ixgbe_pull_tail(struct ixgbe_ring *rx_ring,
> > static void ixgbe_dma_sync_frag(struct ixgbe_ring *rx_ring,
> > struct sk_buff *skb)
> > {
> > - /* if the page was released unmap it, else just sync our portion */
> > - if (unlikely(IXGBE_CB(skb)->page_released)) {
> > - dma_unmap_page_attrs(rx_ring->dev, IXGBE_CB(skb)->dma,
> > - ixgbe_rx_pg_size(rx_ring),
> > - DMA_FROM_DEVICE,
> > - IXGBE_RX_DMA_ATTR);
> > - } else if (ring_uses_build_skb(rx_ring)) {
> > + if (ring_uses_build_skb(rx_ring)) {
> > unsigned long offset = (unsigned long)(skb->data) & ~PAGE_MASK;
> > dma_sync_single_range_for_cpu(rx_ring->dev,
> > @@ -1848,6 +1842,14 @@ static void ixgbe_dma_sync_frag(struct ixgbe_ring *rx_ring,
> > skb_frag_size(frag),
> > DMA_FROM_DEVICE);
> > }
> > +
> > + /* If the page was released, just unmap it. */
> > + if (unlikely(IXGBE_CB(skb)->page_released)) {
> > + dma_unmap_page_attrs(rx_ring->dev, IXGBE_CB(skb)->dma,
> > + ixgbe_rx_pg_size(rx_ring),
> > + DMA_FROM_DEVICE,
> > + IXGBE_RX_DMA_ATTR);
> > + }
> > }
> > /**
>
next prev parent reply other threads:[~2019-08-07 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 2:49 [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally Firo Yang
2019-08-07 7:56 ` Jacob Wen
2019-08-07 8:38 ` Firo Yang [this message]
[not found] ` <20190807160853.00001d71@gmail.com>
2019-08-07 16:06 ` [Intel-wired-lan] " Alexander Duyck
2019-08-08 1:55 ` Firo Yang
2019-08-08 1:56 ` Jacob Wen
2019-08-08 3:48 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807083831.GA6811@linux-6qg8 \
--to=firo.yang@suse.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jian.w.wen@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).