From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7693FC32751 for ; Wed, 7 Aug 2019 15:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DA9022295 for ; Wed, 7 Aug 2019 15:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565191340; bh=fT682hdrISgNXZBslLUtKlTZkoUPbA02ONx4Yr2ztgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Vwe1s03ZuO8Vqn3Q3S3zesCncJO+sX4m2dPiGhqK2yKMKOtz7GpvD9WvRNGS0L0xn l7eKX7A8Ke2K2j2ZqyE62JJ9PVz5nXSXetA3j91r/UsOd9NlCCg/YNZ3gAcwYGaVOt jonZEBjeUFlwxHNb1c72JA3fI4Z/89LiONe3J3Mw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388492AbfHGPWT (ORCPT ); Wed, 7 Aug 2019 11:22:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388257AbfHGPWT (ORCPT ); Wed, 7 Aug 2019 11:22:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C833D2199C; Wed, 7 Aug 2019 15:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565191338; bh=fT682hdrISgNXZBslLUtKlTZkoUPbA02ONx4Yr2ztgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VotQQBsc3UrvBQjlUi2YgwRp+DsSfCbJclFfcF8tHQ2WamyGB7DQGoHr2EFjZJuIJ Am+K9sRBsnXPEpkBFc1AuyV9eOOKjUFY+ENhRNvHCUumqBo2VtoGdOeXMSRjMILiSU sRfB8VINE57EjSFue1lZmDmMvytu5nWzOMyFXtys= Date: Wed, 7 Aug 2019 17:22:15 +0200 From: Greg KH To: Christoph Hellwig Cc: palmer@sifive.com, arnd@arndb.de, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/misc Message-ID: <20190807152215.GA26690@kroah.com> References: <20190807151009.31971-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807151009.31971-1-hch@lst.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 06:10:09PM +0300, Christoph Hellwig wrote: > The sifive_l2_cache.c is in no way related to RISC-V architecture > memory management. It is a little stub driver working around the fact > that the EDAC maintainers prefer their drivers to be structured in a > certain way that doesn't fit the SiFive SOCs. > > Move the file to drivers/misc and only build it when the EDAC_SIFIVE > config option is selected. > > Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs") > Signed-off-by: Christoph Hellwig > --- > arch/riscv/mm/Makefile | 1 - > drivers/misc/Makefile | 1 + > {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c | 0 > 3 files changed, 1 insertion(+), 1 deletion(-) > rename {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c (100%) Why isn't this in drivers/edac/ ? why is this a misc driver? Seems like it should sit next to the edac stuff. thanks, greg k-h