linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: amit@kernel.org, mst@redhat.com, arnd@arndb.de,
	virtualization@lists.linux-foundation.org, jasowang@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] virtio_console: free unused buffers with port delete
Date: Thu, 8 Aug 2019 13:55:55 +0200	[thread overview]
Message-ID: <20190808115555.GA2015@kroah.com> (raw)
In-Reply-To: <20190808113606.19504-2-pagupta@redhat.com>

On Thu, Aug 08, 2019 at 05:06:05PM +0530, Pankaj Gupta wrote:
>   The commit a7a69ec0d8e4 ("virtio_console: free buffers after reset")
>   deferred detaching of unused buffer to virtio device unplug time.
> 
>   This causes unplug/replug of single port in virtio device with an
>   error "Error allocating inbufs\n". As we don't free the unused buffers
>   attached with the port. Re-plug the same port tries to allocate new
>   buffers in virtqueue and results in this error if queue is full.
> 
>   This patch removes the unused buffers in vq's when we unplug the port.
>   This is the best we can do as we cannot call device_reset because virtio
>   device is still active.

Why is this indented?

> 
> Reported-by: Xiaohui Li <xiaohli@redhat.com>
> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset")

Fixes: b3258ff1d608 ("virtio: Decrement avail idx on buffer detach")

is the correct format to use.

And given that this is from 2.6.39 (and 2.6.38.5), shouldn't it also be
backported for the stable kernels?

thanks,

greg k-h

  reply	other threads:[~2019-08-08 11:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 11:36 [PATCH v2 0/2] virtio_console: fix replug of virtio console port Pankaj Gupta
2019-08-08 11:36 ` [PATCH v2 1/2] virtio_console: free unused buffers with port delete Pankaj Gupta
2019-08-08 11:55   ` Greg KH [this message]
2019-08-08 12:19     ` Pankaj Gupta
2019-08-08 11:36 ` [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf Pankaj Gupta
2019-08-08 11:56   ` Greg KH
2019-08-08 12:28     ` Pankaj Gupta
2019-08-08 12:42       ` Greg KH
2019-08-08 12:44         ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190808115555.GA2015@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amit@kernel.org \
    --cc=arnd@arndb.de \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pagupta@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).