From: Steven Rostedt <rostedt@goodmis.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Jiping Ma <jiping.ma2@windriver.com>,
catalin.marinas@arm.com, will.deacon@arm.com, mingo@redhat.com,
Joel Fernandes <joel@joelfernandes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2 v2] tracing/arm64: Have max stack tracer handle the case of return address after data
Date: Thu, 8 Aug 2019 12:36:32 -0400 [thread overview]
Message-ID: <20190808123632.0dd1a58c@gandalf.local.home> (raw)
In-Reply-To: <20190808162825.7klpu3ffza5zxwrt@willie-the-truck>
On Thu, 8 Aug 2019 17:28:26 +0100
Will Deacon <will@kernel.org> wrote:
> > + * Note, this may change in the future, and we will need to deal with that
> > + * if it were to happen.
> > + */
> > +#define ARCH_RET_ADDR_AFTER_LOCAL_VARS 1
>
> I know it's long already, but prefixing this with FTRACE_ would be good so
> that other code doesn't use it for anything. It's not the end of the world
> if the ftrace stack usage statistics are wonky, but if people tried to use
> this for crazy things like livepatching then we'd be in trouble.
>
> Maybe FTRACE_ARCH_FRAME_AFTER_LOCALS, which is the same length as what
> you currently have?
Note, it would still need to be prefixed with "ARCH_" as that's the way
of showing arch specific defines.
We could make it more descriptive of what it will do and not the reason
for why it is done...
ARCH_FTRACE_SHIFT_STACK_TRACER
?
-- Steve
next prev parent reply other threads:[~2019-08-08 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 17:28 [PATCH 0/2 v2] tracing/arm: Fix the stack tracer when LR is saved after local storage Steven Rostedt
2019-08-07 17:28 ` [PATCH 1/2 v2] tracing/arm64: Have max stack tracer handle the case of return address after data Steven Rostedt
2019-08-07 19:29 ` Steven Rostedt
2019-08-08 16:28 ` Will Deacon
2019-08-08 16:36 ` Steven Rostedt [this message]
2019-08-08 17:11 ` Will Deacon
2019-08-08 17:24 ` Steven Rostedt
2019-08-09 2:17 ` Jiping Ma
2019-08-09 2:24 ` Steven Rostedt
2019-08-13 17:31 ` Will Deacon
2019-08-13 17:47 ` Steven Rostedt
2019-08-09 8:55 ` Mark Rutland
2019-08-07 17:28 ` [PATCH 2/2 v2] tracing: Document the stack trace algorithm in the comments Steven Rostedt
2019-08-08 20:17 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808123632.0dd1a58c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=catalin.marinas@arm.com \
--cc=jiping.ma2@windriver.com \
--cc=joel@joelfernandes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).