From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF80C433FF for ; Thu, 8 Aug 2019 13:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9257B21874 for ; Thu, 8 Aug 2019 13:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565270772; bh=xOthRltc9QPDcvSfY6/4aGUZsvl14aXcUqTn5d6Zb0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PsOB1J9xSMOCTd1kgxzwEXbb4+KxdnM/50L/t/McEFUAbTaWcysJ8/o9OBBRgEjhd Xuj5+ODqE0zyMHdIZAwnW2IPlYFagxkWHPb/bHLzq8JY+C6YNOvJTqR1Km2TQwi+6b 4duJ8e7ABcMTYaVl8A6hiI/Q7pa8RGA3pyzLHVbg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733061AbfHHN0L (ORCPT ); Thu, 8 Aug 2019 09:26:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:60560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732643AbfHHN0L (ORCPT ); Thu, 8 Aug 2019 09:26:11 -0400 Received: from localhost (unknown [122.178.245.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B37412171F; Thu, 8 Aug 2019 13:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565270770; bh=xOthRltc9QPDcvSfY6/4aGUZsvl14aXcUqTn5d6Zb0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wdhiSMgEUzklpKCVFzekiTPw8B+at3lhPkMlMq4SDMz7bagefPWO/3Q+YcDzoHCPg vY90keJnw2raAF5MHo3hox17C8WLQGi9gvALi+W9RX1r1qYdChpA4QJ93ZTn9d6Kam koHNlTvuUSrcY+0LQUue/knLXIFACQjNVu0A19FU= Date: Thu, 8 Aug 2019 18:54:56 +0530 From: Vinod Koul To: Jia-Ju Bai Cc: dan.j.williams@intel.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler() Message-ID: <20190808132456.GA12733@vkoul-mobl.Dlink> References: <20190729020849.17971-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729020849.17971-1-baijiaju1990@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-07-19, 10:08, Jia-Ju Bai wrote: > In stm32_mdma_irq_handler(), chan is checked on line 1368. > When chan is NULL, it is still used on line 1369: > dev_err(chan2dev(chan), "MDMA channel not initialized\n"); > > Thus, a possible null-pointer dereference may occur. > > To fix this bug, "dev_dbg(mdma2dev(dmadev), ...)" is used instead. Applied after changing subsystem name in patch title to dmaengine: ..., Also while fixing it helps to add Fixes tag, have added Thanks -- ~Vinod