From: kbuild test robot <lkp@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: kbuild-all@01.org, Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, Pingfan Liu <kernelfans@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>, Qian Cai <cai@lca.pw>,
Vlastimil Babka <vbabka@suse.cz>,
Daniel Drake <drake@endlessm.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Eric Biederman <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>,
kexec@lists.infradead.org
Subject: Re: [PATCH 3/4] x86/smp: send capped cpus to a stable state when smp_init()
Date: Thu, 8 Aug 2019 13:18:16 +0800 [thread overview]
Message-ID: <201908081335.MoXu80jM%lkp@intel.com> (raw)
In-Reply-To: <1564995539-29609-4-git-send-email-kernelfans@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2433 bytes --]
Hi Pingfan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190807]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pingfan-Liu/x86-mce-protect-nr_cpus-from-rebooting-by-broadcast-mce/20190806-101748
config: i386-randconfig-a004-201931 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
ld: arch/x86/kernel/smpboot.o: in function `do_stable_cpu':
>> arch/x86/kernel/smpboot.c:1057: undefined reference to `initial_gs'
vim +1057 arch/x86/kernel/smpboot.c
1048
1049 static void __init do_stable_cpu(int cpu)
1050 {
1051 static char capped_tmp_stack[512];
1052 int cpu0_nmi_registered = 0, apicid = cpuid_to_apicid[cpu];
1053 unsigned long start_ip = real_mode_header->trampoline_start;
1054 unsigned long timeout, boot_error = 0;
1055
1056 /* invalid percpu area */
> 1057 initial_gs = 0;
1058 /*
1059 * Borrow the value of cpu 0. Since capped cpu segment shadow register
1060 * can cache the content, and keep it unchanged.
1061 */
1062 early_gdt_descr.address = (unsigned long)get_cpu_gdt_rw(0);
1063 initial_code = (unsigned long)make_capped_cpu_stable;
1064 initial_stack = (unsigned long)&capped_tmp_stack;
1065
1066 if (apic->wakeup_secondary_cpu)
1067 boot_error = apic->wakeup_secondary_cpu(apicid, start_ip);
1068 else
1069 boot_error = wakeup_cpu_via_init_nmi(cpu, start_ip, apicid,
1070 &cpu0_nmi_registered);
1071 if (cpu0_nmi_registered)
1072 unregister_nmi_handler(NMI_LOCAL, "wake_cpu0");
1073
1074 if (!boot_error) {
1075 /* Wait 10s total for first sign of life from capped cpu */
1076 boot_error = -1;
1077 timeout = jiffies + 10*HZ;
1078 while (time_before(jiffies, timeout)) {
1079 if (cpumask_test_cpu(cpu, cpu_capped_done_mask))
1080 break;
1081 schedule();
1082 }
1083 }
1084 }
1085
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31956 bytes --]
next prev parent reply other threads:[~2019-08-08 5:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 8:58 [PATCH 0/4] x86/mce: protect nr_cpus from rebooting by broadcast mce Pingfan Liu
2019-08-05 8:58 ` [PATCH 1/4] x86/apic: correct the ENO in generic_processor_info() Pingfan Liu
2019-08-05 8:58 ` [PATCH 2/4] x86/apic: record capped cpu " Pingfan Liu
2019-08-08 0:17 ` kbuild test robot
2019-08-08 0:17 ` [RFC PATCH] x86/apic: __cpu_capped_mask can be static kbuild test robot
2019-08-05 8:58 ` [PATCH 3/4] x86/smp: send capped cpus to a stable state when smp_init() Pingfan Liu
2019-08-08 1:20 ` kbuild test robot
2019-08-08 1:20 ` [RFC PATCH] x86/smp: __cpu_capped_done_mask can be static kbuild test robot
2019-08-08 2:36 ` [PATCH 3/4] x86/smp: send capped cpus to a stable state when smp_init() kbuild test robot
2019-08-08 5:18 ` kbuild test robot [this message]
2019-08-05 8:58 ` [PATCH 4/4] x86/smp: disallow MCE handler on rebooting AP Pingfan Liu
2019-08-07 3:00 ` [PATCH 0/4] x86/mce: protect nr_cpus from rebooting by broadcast mce Dave Young
2019-08-07 7:52 ` Pingfan Liu
2019-08-07 13:07 ` Thomas Gleixner
2019-08-08 5:41 ` Pingfan Liu
2019-08-08 6:51 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908081335.MoXu80jM%lkp@intel.com \
--to=lkp@intel.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=dave.hansen@linux.intel.com \
--cc=drake@endlessm.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=kernelfans@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).