From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf tools: Fix include paths in ui
Date: Thu, 8 Aug 2019 10:39:17 -0300 [thread overview]
Message-ID: <20190808133917.GE19444@kernel.org> (raw)
In-Reply-To: <20190731225441.233800-1-irogers@google.com>
Em Wed, Jul 31, 2019 at 03:54:41PM -0700, Ian Rogers escreveu:
> These paths point to the wrong location but still work because they
> get picked up by a -I flag that happens to direct to the correct
> file. Fix paths to point to the correct location without -I flags.
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/ui/browser.c | 9 +++++----
> tools/perf/ui/tui/progress.c | 2 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
> index f80c51d53565..d227d74b28f8 100644
> --- a/tools/perf/ui/browser.c
> +++ b/tools/perf/ui/browser.c
> @@ -1,7 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0
> -#include "../string2.h"
> -#include "../config.h"
> -#include "../../perf.h"
> +#include "../util/util.h"
> +#include "../util/string2.h"
> +#include "../util/config.h"
> +#include "../perf.h"
> #include "libslang.h"
> #include "ui.h"
> #include "util.h"
> @@ -14,7 +15,7 @@
> #include "browser.h"
> #include "helpline.h"
> #include "keysyms.h"
> -#include "../color.h"
> +#include "../util/color.h"
> #include <linux/ctype.h>
> #include <linux/zalloc.h>
>
> diff --git a/tools/perf/ui/tui/progress.c b/tools/perf/ui/tui/progress.c
> index bc134b82829d..5a24dd3ce4db 100644
> --- a/tools/perf/ui/tui/progress.c
> +++ b/tools/perf/ui/tui/progress.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <linux/kernel.h>
> -#include "../cache.h"
> +#include "../../util/cache.h"
> #include "../progress.h"
> #include "../libslang.h"
> #include "../ui.h"
> --
> 2.22.0.770.g0f2c4a37fd-goog
--
- Arnaldo
next prev parent reply other threads:[~2019-08-08 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 22:54 [PATCH] perf tools: Fix include paths in ui Ian Rogers
2019-08-08 13:39 ` Arnaldo Carvalho de Melo [this message]
2019-08-08 20:20 ` [tip:perf/urgent] perf tools: Fix include paths in ui directory tip-bot for Ian Rogers
2019-09-04 18:00 [PATCH] perf tools: Fix include paths in ui Ian Rogers
2019-09-04 18:07 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808133917.GE19444@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).