From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03248C433FF for ; Thu, 8 Aug 2019 23:09:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7C5E21743 for ; Thu, 8 Aug 2019 23:09:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dbDwiA4A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404740AbfHHXJH (ORCPT ); Thu, 8 Aug 2019 19:09:07 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44064 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404422AbfHHXJH (ORCPT ); Thu, 8 Aug 2019 19:09:07 -0400 Received: by mail-pl1-f195.google.com with SMTP id t14so44132012plr.11 for ; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=dbDwiA4Adn6NNb5EvA73thvbmUP2keuqre4+n/NxwEHqhexDztnDaNh7AsRSTZZe49 hYpD3IzLcNsObNJn7jV0JwQOyof3bHoudWE9xbxMphJZ3xC6+cAju3iiWanCTUgT+RRy 5BTDqjSStXzv50strdYe4GteQ70uxl48L/KiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PshILyRjCCo0C5QCJz7frN2AnaNP8oJw8QYaH2iANig=; b=MGdUoIQLDIK/ZwH+Lwt+IJrgjD4ff+yCqV6o7z3uwqhdYBJve5/jzvtQZKAEOUBxe0 C+pBaMzX09xUXq55Czj8UPQmhKbXtj10mX0ecXbx+1KWp2qYnM3LGqLqBZT5IcTT8kWo fFd3qZ/XmDzN0pk7bY/XiYiwkFnAAFyCazIMune7vdwyS6Iq6sPum4pi6tNtEJaAv55o SzG7D57v/cjA9V74bN/iZqAH+4BfW29OvlKlXoopqLdvSTv+K0X31DquFb5QfF7PPbrk Fk3l4vrRZ0nE8kGNg+c0zFhIqo6dGTJHmS0AjLrulPXDXSOpLIBKZUsdcBHVoUipoM+K tudg== X-Gm-Message-State: APjAAAUJhAR9Q4TkHiuoRMJH3twjzfSzEOod99+yIeEzB9D74njpVLZI YUooa9e7Q8SCzawJXdcXcSpkKQ== X-Google-Smtp-Source: APXvYqwRMwQCoIwwE1SVnXBBenp7lYzRwUiHs8nPiovNgZn+1R84ViErtlLi11BYuAEM5u5dpbcusw== X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr15179356ply.251.1565305746634; Thu, 08 Aug 2019 16:09:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o130sm157376311pfg.171.2019.08.08.16.09.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Aug 2019 16:09:05 -0700 (PDT) Date: Thu, 8 Aug 2019 16:09:04 -0700 From: Kees Cook To: Andrew Morton Cc: Andrey Konovalov , Will Deacon , Will Deacon , Vincenzo Frascino , Catalin Marinas , Mark Rutland , kvm@vger.kernel.org, Szabolcs Nagy , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , "open list:KERNEL SELFTEST FRAMEWORK" , Felix Kuehling , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Linux ARM , Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Kevin Brodsky , Ruben Ayrapetyan , Ramana Radhakrishnan , Alex Williamson , Mauro Carvalho Chehab , Dmitry Vyukov , Linux Memory Management List , Greg Kroah-Hartman , Yishai Hadas , LKML , Jens Wiklander , Lee Smith , Alexander Deucher , enh , Robin Murphy , Christian Koenig , Luc Van Oostenryck Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook