From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEDAC433FF for ; Thu, 8 Aug 2019 18:54:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEF0421881 for ; Thu, 8 Aug 2019 18:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565290475; bh=Uw+wdcUXSH9ec44296N2fYl6K1u8+h+NAtLXcX3f73Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cyQ36KFgQtXsxq4SwnW1oipsO3I2Nu2SkMQdZqWnQLZBgT4eZ0MC41YDdtmajSHAv 8DGfcctN0mBf7DUYRnb8OiVGp/y+oMmwBHQSLvw9RV10uHB7E0ZQjv7MCQxOSwirXV kfwfseo6tiiDv1f+ONrn8d2K4SajJvMaLD7HCuiw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404086AbfHHSyd (ORCPT ); Thu, 8 Aug 2019 14:54:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390228AbfHHSyd (ORCPT ); Thu, 8 Aug 2019 14:54:33 -0400 Received: from quaco.ghostprotocols.net (unknown [177.195.210.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8EC72184E; Thu, 8 Aug 2019 18:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565290472; bh=Uw+wdcUXSH9ec44296N2fYl6K1u8+h+NAtLXcX3f73Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0hySTq9nTqbr8/vM7oTyJf8X2fm2QwglOyeFpAvip6PVycvnafGGnfQiQzeJAMxV3 IPt8TFThKPLW2FBemxudHaaGYLskv4I6Ic8YdjJGAr2CYROOjXN+WilV4Obv8VP+1x /tJVQ1mmjYmxt/ItwHJRBMofU0VilyZyOHxuWfOk= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Michael Petlan , Alexander Shishkin , Andi Kleen , Peter Zijlstra , Satheesh Rajendran , Arnaldo Carvalho de Melo Subject: [PATCH 01/10] perf bench numa: Fix cpu0 binding Date: Thu, 8 Aug 2019 15:53:49 -0300 Message-Id: <20190808185358.20125-2-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190808185358.20125-1-acme@kernel.org> References: <20190808185358.20125-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa Michael reported an issue with perf bench numa failing with binding to cpu0 with '-0' option. # perf bench numa mem -p 3 -t 1 -P 512 -s 100 -zZcm0 --thp 1 -M 1 -ddd # Running 'numa/mem' benchmark: # Running main, "perf bench numa numa-mem -p 3 -t 1 -P 512 -s 100 -zZcm0 --thp 1 -M 1 -ddd" binding to node 0, mask: 0000000000000001 => -1 perf: bench/numa.c:356: bind_to_memnode: Assertion `!(ret)' failed. Aborted (core dumped) This happens when the cpu0 is not part of node0, which is the benchmark assumption and we can see that's not the case for some powerpc servers. Using correct node for cpu0 binding. Reported-by: Michael Petlan Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Satheesh Rajendran Link: http://lkml.kernel.org/r/20190801142642.28004-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/bench/numa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c index a640ca7aaada..513cb2f2fa32 100644 --- a/tools/perf/bench/numa.c +++ b/tools/perf/bench/numa.c @@ -379,8 +379,10 @@ static u8 *alloc_data(ssize_t bytes0, int map_flags, /* Allocate and initialize all memory on CPU#0: */ if (init_cpu0) { - orig_mask = bind_to_node(0); - bind_to_memnode(0); + int node = numa_node_of_cpu(0); + + orig_mask = bind_to_node(node); + bind_to_memnode(node); } bytes = bytes0 + HPSIZE; -- 2.21.0