From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F109FC0650F for ; Thu, 8 Aug 2019 19:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C313221883 for ; Thu, 8 Aug 2019 19:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291176; bh=dNmTb3QINlrpcp+OKj14SrI5Ih/AaDAsr/lQUlLus38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=igGMbqsVq4kqI0Hll9ciosBa+wEYzT8fRT8dq6jW+YZyAvSXhu8TBeiPNNPeh6/Sc OER8xr7a3/5/5+kjLCp7O+2dk9tOWvpOlyh7LPVrpAh1+VsS012J6TEVHvoDDGvqJF Bsbbhk9ZcpL6Mc8x/KSRrP74xjKLjfLHl9Jqzn0s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404335AbfHHTGP (ORCPT ); Thu, 8 Aug 2019 15:06:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404305AbfHHTGM (ORCPT ); Thu, 8 Aug 2019 15:06:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B40721874; Thu, 8 Aug 2019 19:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291171; bh=dNmTb3QINlrpcp+OKj14SrI5Ih/AaDAsr/lQUlLus38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pkvsv7wZBw832a7gqZe6sIEnqe0WyR7D5adWmFSx4uWunJqGO0+rZ04Ds9UGZFylb Erf7WjygUFdRcLFCe8f72cDPKrBK4lDsRsobvxwCMiSBJSaXQsTUDwjOFoVaGoNlbK r13Z6pdd4IIiou81k/YAi946K7pkmUpChsNuplM8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haishuang Yan , "David S. Miller" Subject: [PATCH 5.2 14/56] ipip: validate header length in ipip_tunnel_xmit Date: Thu, 8 Aug 2019 21:04:40 +0200 Message-Id: <20190808190453.428439547@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190808190452.867062037@linuxfoundation.org> References: <20190808190452.867062037@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haishuang Yan [ Upstream commit 47d858d0bdcd47cc1c6c9eeca91b091dd9e55637 ] We need the same checks introduced by commit cb9f1b783850 ("ip: validate header length on virtual device xmit") for ipip tunnel. Fixes: cb9f1b783850b ("ip: validate header length on virtual device xmit") Signed-off-by: Haishuang Yan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -275,6 +275,9 @@ static netdev_tx_t ipip_tunnel_xmit(stru const struct iphdr *tiph = &tunnel->parms.iph; u8 ipproto; + if (!pskb_inet_may_pull(skb)) + goto tx_error; + switch (skb->protocol) { case htons(ETH_P_IP): ipproto = IPPROTO_IPIP;