From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68424C0650F for ; Thu, 8 Aug 2019 19:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 315EE2184E for ; Thu, 8 Aug 2019 19:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291381; bh=fPjyKWjqbff7ewKV5FEwt3VJernzWM6g/qqYgqjs4WU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=c20khRGMioVKOuQgzXA6AN0h1npc95IFFOjJa7ePEBz5t+jTqhVq9g2xR2gCOIZiY 5SteD0lSIjn+5vHF04D3qNA1G6lcnM9P0lY0Pi+lBuE2syPHzbcnwZGftik3R/KjBQ zlQvJ6O8TgldpDJrqttMLLD24bssMGG2zsGxaVOs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405148AbfHHTJk (ORCPT ); Thu, 8 Aug 2019 15:09:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:43936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405117AbfHHTJg (ORCPT ); Thu, 8 Aug 2019 15:09:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE36021743; Thu, 8 Aug 2019 19:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291375; bh=fPjyKWjqbff7ewKV5FEwt3VJernzWM6g/qqYgqjs4WU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hulqs+/NfW6bkrMwkPMzQP2ua79xeTUAB/SPicZPa9tD8vhw4ukPm2wpw/sFhsbA9 9qbNggypMsi1a2yjrM1HzkIp8PTaYCRdQmwDPBfcD635sZyXKoPy+LaF1SyZAFB9JX JQxTuSexmu4DOqVmkFCuhl5z8svntr8PZ+vT9LDU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Pirko , Ido Schimmel , "David S. Miller" Subject: [PATCH 4.19 18/45] mlxsw: spectrum: Fix error path in mlxsw_sp_module_init() Date: Thu, 8 Aug 2019 21:05:04 +0200 Message-Id: <20190808190454.757996450@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190808190453.827571908@linuxfoundation.org> References: <20190808190453.827571908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Pirko [ Upstream commit 28fe79000e9b0a6f99959869947f1ca305f14599 ] In case of sp2 pci driver registration fail, fix the error path to start with sp1 pci driver unregister. Fixes: c3ab435466d5 ("mlxsw: spectrum: Extend to support Spectrum-2 ASIC") Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -5032,7 +5032,7 @@ static int __init mlxsw_sp_module_init(v return 0; err_sp2_pci_driver_register: - mlxsw_pci_driver_unregister(&mlxsw_sp2_pci_driver); + mlxsw_pci_driver_unregister(&mlxsw_sp1_pci_driver); err_sp1_pci_driver_register: mlxsw_core_driver_unregister(&mlxsw_sp2_driver); err_sp2_core_driver_register: