From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6646BC433FF for ; Thu, 8 Aug 2019 20:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 312832173C for ; Thu, 8 Aug 2019 20:34:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0hOmMEjL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390414AbfHHUeU (ORCPT ); Thu, 8 Aug 2019 16:34:20 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45646 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390399AbfHHUeT (ORCPT ); Thu, 8 Aug 2019 16:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FlJZGarl3bbH3/pyryWmZ82ojdu1jbJlpm/J+vJz06E=; b=0hOmMEjLp44q+7Z8ZdVCOhSsF9 7CyBnLfLvJ1CyenbpGxPQMBPANu+U6FuuTVEuJJ5/LFOqLZdr3L2yhNMg+kPSgXIzGqa2kXPsmNdR Fa+uXbdefu/j/qdkCPFepaJ65tYYDId6vPRGgjLEri+RhGRnBYgCeGAuu3voLKEVaaSk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hvp71-0005sf-1V; Thu, 08 Aug 2019 22:34:15 +0200 Date: Thu, 8 Aug 2019 22:34:15 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Yonglong Liu , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, yisen.zhuang@huawei.com, shiju.jose@huawei.com Subject: Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status Message-ID: <20190808203415.GO27917@lunn.ch> References: <1565183772-44268-1-git-send-email-liuyonglong@huawei.com> <080b68c7-abe6-d142-da4b-26e8a7d4dc19@gmail.com> <20190808194049.GM27917@lunn.ch> <26e2c5c9-915c-858b-d091-e5bfa7ab6a5b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26e2c5c9-915c-858b-d091-e5bfa7ab6a5b@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 08, 2019 at 10:01:39PM +0200, Heiner Kallweit wrote: > On 08.08.2019 21:40, Andrew Lunn wrote: > >> @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) > >> if (err < 0) > >> goto out_unlock; > >> > >> + /* The PHY may not yet have cleared aneg-completed and link-up bit > >> + * w/o this delay when the following read is done. > >> + */ > >> + usleep_range(1000, 2000); > >> + > > > > Hi Heiner > > > > Does 802.3 C22 say anything about this? > > > C22 says: > "The Auto-Negotiation process shall be restarted by setting bit 0.9 to a logic one. This bit is self- > clearing, and a PHY shall return a value of one in bit 0.9 until the Auto-Negotiation process has been > initiated." > > Maybe we should read bit 0.9 in genphy_update_link() after having read BMSR and report > aneg-complete and link-up as false (no matter of their current value) if 0.9 is set. Yes. That sounds sensible. Andrew