linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Isaku Yamahata <isaku.yamahata@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, toshi.kani@hpe.com,
	fei1.li@intel.com
Subject: Re: [PATCH 0/3] x86/mtrr, pat: make PAT independent from MTRR
Date: Fri, 9 Aug 2019 09:06:47 +0200	[thread overview]
Message-ID: <20190809070647.GA2152@zn.tnic> (raw)
In-Reply-To: <cover.1565300606.git.isaku.yamahata@gmail.com>

On Thu, Aug 08, 2019 at 08:54:17PM -0700, Isaku Yamahata wrote:
> Make PAT(Page Attribute Table) independent from
> MTRR(Memory Type Range Register).
> Some environments (mainly virtual ones) support only PAT, but not MTRR
> because PAT replaces MTRR.
> It's tricky and no gain to support both MTRR and PAT except compatibility.
> So some VM technologies don't support MTRR, but only PAT.
> This patch series makes PAT available on such environments without MTRR.

And this "justification" is not even trying. Which "VM technologies" are
those? Why do we care? What's the impact? Why do we want this?

You need to sell this properly.

Also, your patches are huge. You'd need to split them sensibly.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  parent reply	other threads:[~2019-08-09  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  3:54 [PATCH 0/3] x86/mtrr, pat: make PAT independent from MTRR Isaku Yamahata
2019-08-09  3:54 ` [PATCH 1/3] x86/mtrr: split common funcs from mtrr.c Isaku Yamahata
2019-08-09  3:54 ` [PATCH 2/3] x86/mtrr: split common funcs from generic.c Isaku Yamahata
2019-08-09  3:54 ` [PATCH 3/3] x86/mtrr, pat: make PAT independent from MTRR Isaku Yamahata
2019-08-09  7:06 ` Borislav Petkov [this message]
2019-08-09 19:51   ` [PATCH 0/3] " Kani, Toshi
2019-08-13  7:49     ` Isaku Yamahata
2019-08-13  8:04       ` Borislav Petkov
2019-08-13 15:07       ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809070647.GA2152@zn.tnic \
    --to=bp@alien8.de \
    --cc=fei1.li@intel.com \
    --cc=isaku.yamahata@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).