* [PATCH] staging: wusbcore: Fix build error without CONFIG_USB
@ 2019-08-09 10:21 YueHaibing
2019-08-09 12:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-09 10:21 UTC (permalink / raw)
To: gregkh, ard.biesheuvel; +Cc: linux-kernel, devel, YueHaibing
USB_WUSB should depends on CONFIG_USB, otherwise building fails
drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/wusbcore/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
index 056c60b..a559d02 100644
--- a/drivers/staging/wusbcore/Kconfig
+++ b/drivers/staging/wusbcore/Kconfig
@@ -4,7 +4,7 @@
#
config USB_WUSB
tristate "Enable Wireless USB extensions"
- depends on UWB
+ depends on UWB && USB
select CRYPTO
select CRYPTO_AES
select CRYPTO_CCM
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB
2019-08-09 10:21 [PATCH] staging: wusbcore: Fix build error without CONFIG_USB YueHaibing
@ 2019-08-09 12:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-08-09 12:56 UTC (permalink / raw)
To: YueHaibing; +Cc: ard.biesheuvel, devel, linux-kernel
On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote:
> USB_WUSB should depends on CONFIG_USB, otherwise building fails
>
> drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
> wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/wusbcore/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
> index 056c60b..a559d02 100644
> --- a/drivers/staging/wusbcore/Kconfig
> +++ b/drivers/staging/wusbcore/Kconfig
> @@ -4,7 +4,7 @@
> #
> config USB_WUSB
> tristate "Enable Wireless USB extensions"
> - depends on UWB
> + depends on UWB && USB
> select CRYPTO
> select CRYPTO_AES
> select CRYPTO_CCM
> --
> 2.7.4
Ah, good catch, sorry about that!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-09 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 10:21 [PATCH] staging: wusbcore: Fix build error without CONFIG_USB YueHaibing
2019-08-09 12:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).