From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A936EC31E40 for ; Fri, 9 Aug 2019 21:22:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7994120844 for ; Fri, 9 Aug 2019 21:22:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="T0xdr3m2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbfHIVW1 (ORCPT ); Fri, 9 Aug 2019 17:22:27 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36989 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727436AbfHIVW0 (ORCPT ); Fri, 9 Aug 2019 17:22:26 -0400 Received: by mail-qt1-f193.google.com with SMTP id y26so97244205qto.4 for ; Fri, 09 Aug 2019 14:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Ug4MTgi2ueZfqMA4+FWSQr133wSyuN+mgZsk4RxY5I8=; b=T0xdr3m2vk1dRABuDHdagNOsvCUEuquJMDDxB4gyWa18mibI8q1Vl2M6UddZGZuoWW bVUPPg4jkfLa01tuKqceOyPnbi9/T9qyxZo8eXdnZjta40CecwXDLsVLjSwlIwd8TnCx aSKa6IzN3mnKHnng1qTOazZiG7hYxV8s5NDQ5gg57ii+DIvjBI4EAo8h2D1ctIrW7Ogy wb3138VaA4Hi8b6nhh8BQ8xYtUBvPhH2REMBZQlFJw+frygxw/RvqwrnBeusxiEt/6gG V0YnG6ULca5e8RNwu3ogTlbKFOwvOjbG6CzJrOvQ4VB0+sSAdwpat07fvTDXm//+YTms RyAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Ug4MTgi2ueZfqMA4+FWSQr133wSyuN+mgZsk4RxY5I8=; b=tL2fEQky9O1+wwGoc0iRJOYGhrGKnPW8fIRXDGaS2d2+FTblBmPm9dcNhODNLIJOl2 fRlF71aCewYUpibksXkLOfTU4stV/b7Cp/j1br3exE7d1XP3iYDCNd44x1YISyw+0sL8 p43sEt5ApvTqBZ/7v8L8lUC4ysXoui89bJdrw6dBDiffMIfa7VBhg2+NrPQ4mQU1UsAs d7a9/x4zvndEgbq2hPjCbSvVNQk8ZvO/mIIdWs5evCWfRnR7PkUNepID4Dla5yfzOvnb u4nsoxF43LELsOeZ8dvQNubucEhn5RKYZQdNni5ycXFUsTX7CJzUHEWyXo8y0YhgkrBO rpGA== X-Gm-Message-State: APjAAAWV/adH4fsUyKZTiLJytZCY+AXBdR7GYvDH8jDeagJ2sINUBopv XuGMUurl/sHq3R7zZgc5Q3Cvqw== X-Google-Smtp-Source: APXvYqxHJ16TPbArOOObvex2qGMXiPYuuTyPvcouM0eg7EGKkUFhFNbpUw6MquRPUl6SIdbH5N+5zQ== X-Received: by 2002:ac8:252e:: with SMTP id 43mr19908152qtm.61.1565385745973; Fri, 09 Aug 2019 14:22:25 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id p3sm63655473qta.12.2019.08.09.14.22.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 14:22:25 -0700 (PDT) Date: Fri, 9 Aug 2019 14:22:22 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Evgeniy Polyakov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip Message-ID: <20190809142222.4558691e@cakuba.netronome.com> In-Reply-To: <20190809103235.16338-8-tbogendoerfer@suse.de> References: <20190809103235.16338-1-tbogendoerfer@suse.de> <20190809103235.16338-8-tbogendoerfer@suse.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Aug 2019 12:32:29 +0200, Thomas Bogendoerfer wrote: > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > It also supports connecting a SuperIO chip for serial and parallel > interfaces. IOC3 is used inside various SGI systemboards and add-on > cards with different equipped external interfaces. > > Support for ethernet and serial interfaces were implemented inside > the network driver. This patchset moves out the not network related > parts to a new MFD driver, which takes care of card detection, > setup of platform devices and interrupt distribution for the subdevices. > > Serial portion: Acked-by: Greg Kroah-Hartman > > Signed-off-by: Thomas Bogendoerfer There are a lot of changes in the ethernet part which are not easy to explain by the introduction of the other MFD parts.. Could you possibly break this change up into smaller chunks? Also please don't use stdint types in the kernel, please try checkpatch to catch coding style issues.