From: Nathan Chancellor <natechancellor@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang
Date: Sat, 10 Aug 2019 20:17:15 -0700 [thread overview]
Message-ID: <20190811031715.GA22334@archlinux-threadripper> (raw)
In-Reply-To: <871efd6113ee2f6491410409511b871b7637f9e3.camel@perches.com>
On Sat, Aug 10, 2019 at 08:06:05PM -0700, Joe Perches wrote:
> On Sat, 2019-08-10 at 19:04 -0700, Nathan Chancellor wrote:
> > On a tangential note, how are you planning on doing the fallthrough
> > comment to attribute conversion? The reason I ask is clang does not
> > support the comment annotations, meaning that when Nathan Huckleberry's
> > patch is applied to clang (which has been accepted [1]), we are going
> > to get slammed by the warnings. I just ran an x86 defconfig build at
> > 296d05cb0d3c with his patch applied and I see 27673 instances of this
> > warning... (mostly coming from some header files so nothing crazy but it
> > will be super noisy).
> >
> > If you have something to share like a script or patch, I'd be happy to
> > test it locally.
> >
> > [1]: https://reviews.llvm.org/D64838
>
> Something like this patch:
>
> https://lore.kernel.org/patchwork/patch/1108577/
>
> Maybe use:
>
> #define fallthrough [[fallthrough]]
>
> if the compiler supports that notation
>
That patch as it stands will work with D64838, as it is adding support
for the GNU fallthrough attribute.
However, I assume that all of the /* fall through */ comments will need
to be converted to the attribute macro, was that going to be done with
Coccinelle or something else?
next prev parent reply other threads:[~2019-08-11 3:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 22:11 [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang Joe Perches
2019-08-05 22:23 ` Nathan Chancellor
2019-08-10 19:32 ` Joe Perches
2019-08-10 19:44 ` Linus Torvalds
2019-08-10 20:18 ` Joe Perches
2019-08-10 20:33 ` Joe Perches
2019-08-16 19:58 ` rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang) Joe Perches
2019-08-19 23:24 ` rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT Stephen Rothwell
2019-08-20 0:08 ` Joe Perches
2019-08-20 23:28 ` Linus Torvalds
2019-08-20 23:37 ` Joe Perches
2019-08-21 0:39 ` Linus Torvalds
2019-08-26 8:58 ` Geert Uytterhoeven
2019-08-21 0:20 ` Joe Perches
2019-08-21 0:43 ` Linus Torvalds
2019-08-21 0:58 ` stracpy Joe Perches
2019-08-21 4:01 ` rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT Willy Tarreau
2019-08-21 0:33 ` Stephen Rothwell
2019-08-11 2:04 ` [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang Nathan Chancellor
2019-08-11 3:06 ` Joe Perches
2019-08-11 3:17 ` Nathan Chancellor [this message]
2019-08-11 3:54 ` Joe Perches
2019-08-12 5:07 ` Joe Perches
2019-08-11 6:50 ` Bernd Petrovitsch
2019-08-12 16:28 ` Nick Desaulniers
2019-08-12 17:42 ` Joe Perches
2019-08-13 12:44 ` Miguel Ojeda
2019-08-15 2:44 ` Joe Perches
2019-08-16 8:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190811031715.GA22334@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).