From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2466AC433FF for ; Mon, 12 Aug 2019 07:40:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA0932085A for ; Mon, 12 Aug 2019 07:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbfHLHkd (ORCPT ); Mon, 12 Aug 2019 03:40:33 -0400 Received: from verein.lst.de ([213.95.11.211]:45800 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfHLHkd (ORCPT ); Mon, 12 Aug 2019 03:40:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 82E3568BFE; Mon, 12 Aug 2019 09:40:29 +0200 (CEST) Date: Mon, 12 Aug 2019 09:40:29 +0200 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , Bharata B Rao , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" Subject: Re: [PATCH 2/5] resource: add a not device managed request_free_mem_region variant Message-ID: <20190812074029.GA4709@lst.de> References: <20190811081247.22111-1-hch@lst.de> <20190811081247.22111-3-hch@lst.de> <20190811225252.GB15116@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811225252.GB15116@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 11, 2019 at 10:52:58PM +0000, Jason Gunthorpe wrote: > It is a bit jarring to have something called devm_* that doesn't > actually do the devm_ part on some paths. > > Maybe this function should be called __request_free_mem_region() with > another name wrapper macro? Seems like a little more churn than required, but I could do it.