linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3] perf diff: Report noisy for cycles diff
Date: Mon, 12 Aug 2019 10:35:55 +0200	[thread overview]
Message-ID: <20190812083555.GC11752@krava> (raw)
In-Reply-To: <20190809233029.12265-1-yao.jin@linux.intel.com>

On Sat, Aug 10, 2019 at 07:30:29AM +0800, Jin Yao wrote:

SNIP

> +		if (vals[i] != 0)
> +			return 0;
> +	return 1;
> +}
> +
> +static int print_cycles_spark(char *bf, int size, unsigned long *svals, u64 n)
> +{
> +	int len = n, printed;
> +
> +	if (len <= 1)
> +		return 0;
> +
> +	if (len > NUM_SPARKS)
> +		len = NUM_SPARKS;
> +	if (all_zero(svals, len))
> +		return 0;
> +
> +	printed = print_spark(bf, size, svals, len);
> +	printed += scnprintf(bf + printed, size - printed, " ");
> +
> +	if (n > NUM_SPARKS)
> +		printed += scnprintf(bf + printed, size - printed, "..");

will this '..' ever be printed? I can't see that even if I enlarge
the column width..

jirka

  parent reply	other threads:[~2019-08-12  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 23:30 [PATCH v3] perf diff: Report noisy for cycles diff Jin Yao
2019-08-12  8:35 ` Jiri Olsa
2019-08-13  0:40   ` Jin, Yao
2019-08-12  8:35 ` Jiri Olsa
2019-08-13  0:49   ` Jin, Yao
2019-08-12  8:35 ` Jiri Olsa [this message]
2019-08-13  4:13   ` Jin, Yao
2019-08-13 12:14     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812083555.GC11752@krava \
    --to=jolsa@redhat.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).