From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28717C433FF for ; Mon, 12 Aug 2019 08:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F41202070C for ; Mon, 12 Aug 2019 08:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfHLI4M (ORCPT ); Mon, 12 Aug 2019 04:56:12 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40435 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbfHLI4M (ORCPT ); Mon, 12 Aug 2019 04:56:12 -0400 X-Originating-IP: 86.250.200.211 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E3E8460006; Mon, 12 Aug 2019 08:56:04 +0000 (UTC) Date: Mon, 12 Aug 2019 10:56:04 +0200 From: Maxime Ripard To: Yangtao Li Cc: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, mchehab+samsung@kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, Jonathan.Cameron@huawei.com, nicolas.ferre@microchip.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 02/18] dt-bindings: thermal: add binding document for h6 thermal controller Message-ID: <20190812085604.ozhl35wwm3ehlvqn@flea> References: <20190810052829.6032-1-tiny.windzz@gmail.com> <20190810052829.6032-3-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4zhzclyt6oncb76d" Content-Disposition: inline In-Reply-To: <20190810052829.6032-3-tiny.windzz@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4zhzclyt6oncb76d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Aug 10, 2019 at 05:28:13AM +0000, Yangtao Li wrote: > This patch adds binding document for allwinner h6 thermal controller. > > Signed-off-by: Yangtao Li > --- > .../bindings/thermal/sun8i-thermal.yaml | 79 +++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > new file mode 100644 > index 000000000000..e0973199ba3c > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml We've used so far for the schemas the first compatible to introduce that controller as the filename, we should be consistent here. In that case that would be allwinner,sun8i-a23-ths.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > + > +maintainers: > + - Yangtao Li > + > +description: |- > + This describes the device tree binding for the Allwinner thermal > + controller which measures the on-SoC temperatures. > + > +properties: > + compatible: > + enum: > + - allwinner,sun50i-h6-ths > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: bus > + > + "#thermal-sensor-cells": > + const: 1 > + > + nvmem-cells: You need a maxItems here too > + description: ths calibrate data What about something like this: Calibration data for the thermal sensor > + > + nvmem-cell-names: > + const: calib I'm not sure we need a abbreviation here, calibration would be more explicit > + > +required: > + - compatible > + - reg > + - reset > + - clocks > + - clock-names > + - interrupts > + - "#thermal-sensor-cells" > + > +additionalProperties: false > + > +examples: > + - | > + ths: ths@5070400 { > + compatible = "allwinner,sun50i-h6-ths"; > + reg = <0x05070400 0x100>; > + clocks = <&ccu CLK_BUS_THS>; > + clock-names = "bus"; > + resets = <&ccu RST_BUS_THS>; > + interrupts = ; Those examples won't compile. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --4zhzclyt6oncb76d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXVEppAAKCRDj7w1vZxhR xbePAQD4oGzekU98J4bCgNXtImN3X9EeDQ3DpYjvOJSUQtIlZgEAnRIw2ceIxFC7 AomJrBOwFCYE3Ly30TnJfIXLEPZvYAU= =Si6e -----END PGP SIGNATURE----- --4zhzclyt6oncb76d--