From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE21C31E40 for ; Mon, 12 Aug 2019 15:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BC11208C2 for ; Mon, 12 Aug 2019 15:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbfHLPnq (ORCPT ); Mon, 12 Aug 2019 11:43:46 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46401 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfHLPnq (ORCPT ); Mon, 12 Aug 2019 11:43:46 -0400 Received: by mail-qk1-f194.google.com with SMTP id r4so77159660qkm.13 for ; Mon, 12 Aug 2019 08:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p6DR/OYzfN+vBNP6q9yfF8yIqpIgtHE8+UL4dlkfU30=; b=oJp1jeOojsr3b0LD6fJn0UCs6zy6kq3mtgU3AQzPG1UdkvKwBDf/O9IyOS5+rpX5a8 MBgTKYfD5cYOFvq8Hg9OKqUYDco1TX/vdVj+x2+t+40doU5Xgo5MAK1j4xw/izIbsc3A k45EYpyAq/wIlqWkjiSoZOeVKZc4NyVR+oMQWgJCXyklDr0xoCRmLy2S5KSo4nyTO+V9 obhBH1Pa60vmvU79JTJtSZLa9OphTR2A5peIwcYcwnqFIzN6hErLiuMTAqPRDUChOMkD KTqLG2VUh+vGz0LMumhJ5LSM8h2FFuZ+817XpWXa6/Lw1ksaZjSYbVs3jw7TGKR22sEm A7LA== X-Gm-Message-State: APjAAAXbiYyXGTEMQKOBUoTT0XuYaBw4G1E332XVlqIUi8lP/bvb2SL6 cWGjaXPa6s5SSdDdZg7VLTBv8A== X-Google-Smtp-Source: APXvYqxqdBbAl7HwqLwogkzmxm32JSi6pIDpBqFOl9pCZpI2YN6+NOeak0SuGGqnKQRcwszCP6Nqzg== X-Received: by 2002:a37:5d07:: with SMTP id r7mr30078310qkb.4.1565624625037; Mon, 12 Aug 2019 08:43:45 -0700 (PDT) Received: from redhat.com (bzq-79-181-91-42.red.bezeqint.net. [79.181.91.42]) by smtp.gmail.com with ESMTPSA id p3sm68510245qta.12.2019.08.12.08.43.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 08:43:43 -0700 (PDT) Date: Mon, 12 Aug 2019 11:43:36 -0400 From: "Michael S. Tsirkin" To: Alexander Duyck Cc: Nitesh Narayan Lal , kvm list , David Hildenbrand , Dave Hansen , LKML , linux-mm , Andrew Morton , Yang Zhang , pagupta@redhat.com, Rik van Riel , Konrad Rzeszutek Wilk , Matthew Wilcox , lcapitulino@redhat.com, wei.w.wang@intel.com, Andrea Arcangeli , Paolo Bonzini , dan.j.williams@intel.com, Alexander Duyck Subject: Re: [PATCH v4 6/6] virtio-balloon: Add support for providing unused page reports to host Message-ID: <20190812114256-mutt-send-email-mst@kernel.org> References: <20190807224037.6891.53512.stgit@localhost.localdomain> <20190807224219.6891.25387.stgit@localhost.localdomain> <20190812055054-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 08:20:43AM -0700, Alexander Duyck wrote: > On Mon, Aug 12, 2019 at 2:53 AM Michael S. Tsirkin wrote: > > > > On Wed, Aug 07, 2019 at 03:42:19PM -0700, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > --- a/include/uapi/linux/virtio_balloon.h > > > +++ b/include/uapi/linux/virtio_balloon.h > > > @@ -36,6 +36,7 @@ > > > #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon on OOM */ > > > #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */ > > > #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */ > > > +#define VIRTIO_BALLOON_F_REPORTING 5 /* Page reporting virtqueue */ > > > > > > /* Size of a PFN in the balloon interface. */ > > > #define VIRTIO_BALLOON_PFN_SHIFT 12 > > > > Just a small comment: same as any feature bit, > > or indeed any host/guest interface changes, please > > CC virtio-dev on any changes to this UAPI file. > > We must maintain these in the central place in the spec, > > otherwise we run a risk of conflicts. > > > > Okay, other than that if I resubmit with the virtio-dev list added to > you thing this patch set is ready to be acked and pulled into either > the virtio or mm tree assuming there is no other significant feedback > that comes in? > > Thanks. > > - Alex >From my POV yes. If it's my tree acks by mm folks will be necessary. -- MST