From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827FAC31E40 for ; Mon, 12 Aug 2019 14:21:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54498214C6 for ; Mon, 12 Aug 2019 14:21:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DVXmRu46" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728100AbfHLOVa (ORCPT ); Mon, 12 Aug 2019 10:21:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53508 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbfHLOV2 (ORCPT ); Mon, 12 Aug 2019 10:21:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z/HBAAdVzJjxPcR3Fpa0Bj/dMGp3a7DDAeyxrRuUx+U=; b=DVXmRu46PcxYsFuo2VV1To2Jl/ BbQEqql4SCvhQFU3R6KirxTLmIHxPjjPiDSroFnI5O0RXQKlR1uef2MtYhvmUT0L6KppQzoC6FDoc 0Apyj7k+YF/UUvGGyoxXIRa/w0PqB6HIdqAI6eQAkwvcbaIAOZAXV5b3UiXhgg2ohW2k=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hxBCN-0000oi-5x; Mon, 12 Aug 2019 16:21:23 +0200 Date: Mon, 12 Aug 2019 16:21:23 +0200 From: Andrew Lunn To: Alexandru Ardelean Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH v4 12/14] net: phy: adin: implement downshift configuration via phy-tunable Message-ID: <20190812142123.GQ14290@lunn.ch> References: <20190812112350.15242-1-alexandru.ardelean@analog.com> <20190812112350.15242-13-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812112350.15242-13-alexandru.ardelean@analog.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 02:23:48PM +0300, Alexandru Ardelean wrote: > Down-speed auto-negotiation may not always be enabled, in which case the > PHY won't down-shift to 100 or 10 during auto-negotiation. > > This change enables downshift and configures the number of retries to > default 4 (which is also in the datasheet > > The downshift control mechanism can also be controlled via the phy-tunable > interface (ETHTOOL_PHY_DOWNSHIFT control). > > The change has been adapted from the Aquantia PHY driver. > > Signed-off-by: Alexandru Ardelean Reviewed-by: Andrew Lunn Andrew