From: Christoph Hellwig <hch@infradead.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org, schwab@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: fix flush_tlb_range() end address for flush_tlb_page()
Date: Mon, 12 Aug 2019 07:43:37 -0700 [thread overview]
Message-ID: <20190812144337.GA26897@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1908080923320.31070@viisi.sifive.com>
> #define flush_tlb_range(vma, start, end) \
> remote_sfence_vma(mm_cpumask((vma)->vm_mm), start, (end) - (start))
> -#define flush_tlb_mm(mm) \
> +
> +static inline void flush_tlb_page(struct vm_area_struct *vma,
> + unsigned long addr) {
> + flush_tlb_range(vma, addr, addr + PAGE_SIZE);
> +}
Please put the opening brace on a line of its own.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-08-12 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:25 [PATCH] riscv: fix flush_tlb_range() end address for flush_tlb_page() Paul Walmsley
2019-08-12 14:43 ` Christoph Hellwig [this message]
2019-08-13 21:03 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812144337.GA26897@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).