* [PATCH] drm/komeda: Clean warning 'komeda_component_add' might be a candidate for 'gnu_printf'
@ 2019-08-13 11:08 james qian wang (Arm Technology China)
2019-08-22 10:27 ` Ayan Halder
0 siblings, 1 reply; 2+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-08-13 11:08 UTC (permalink / raw)
To: Liviu Dudau, airlied, Brian Starkey, maarten.lankhorst, sean
Cc: Jonathan Chai (Arm Technology China),
Julien Yin (Arm Technology China),
Thomas Sun (Arm Technology China),
Lowry Li (Arm Technology China),
Ayan Halder, Tiannan Zhu (Arm Technology China),
Yiqi Kang (Arm Technology China),
nd, linux-kernel, dri-devel, Ben Davis,
Oscar Zhang (Arm Technology China),
Channing Chen (Arm Technology China),
Mihail Atanassov, james qian wang (Arm Technology China)
komeda/komeda_pipeline.c: In function 'komeda_component_add':
komeda/komeda_pipeline.c:212:3: warning: function 'komeda_component_add' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
vsnprintf(c->name, sizeof(c->name), name_fmt, args);
^~~~~~~~~
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
index a90bcbb3cb23..14b683164544 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
@@ -480,6 +480,7 @@ void komeda_pipeline_dump_register(struct komeda_pipeline *pipe,
struct seq_file *sf);
/* component APIs */
+extern __printf(10, 11)
struct komeda_component *
komeda_component_add(struct komeda_pipeline *pipe,
size_t comp_sz, u32 id, u32 hw_id,
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/komeda: Clean warning 'komeda_component_add' might be a candidate for 'gnu_printf'
2019-08-13 11:08 [PATCH] drm/komeda: Clean warning 'komeda_component_add' might be a candidate for 'gnu_printf' james qian wang (Arm Technology China)
@ 2019-08-22 10:27 ` Ayan Halder
0 siblings, 0 replies; 2+ messages in thread
From: Ayan Halder @ 2019-08-22 10:27 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Liviu Dudau, airlied, Brian Starkey, maarten.lankhorst, sean,
Jonathan Chai (Arm Technology China),
Julien Yin (Arm Technology China),
Thomas Sun (Arm Technology China),
Lowry Li (Arm Technology China),
Tiannan Zhu (Arm Technology China),
Yiqi Kang (Arm Technology China),
nd, linux-kernel, dri-devel, Ben Davis,
Oscar Zhang (Arm Technology China),
Channing Chen (Arm Technology China),
Mihail Atanassov
On Tue, Aug 13, 2019 at 11:08:20AM +0000, james qian wang (Arm Technology China) wrote:
> komeda/komeda_pipeline.c: In function 'komeda_component_add':
> komeda/komeda_pipeline.c:212:3: warning: function 'komeda_component_add' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> ^~~~~~~~~
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
> index a90bcbb3cb23..14b683164544 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h
> @@ -480,6 +480,7 @@ void komeda_pipeline_dump_register(struct komeda_pipeline *pipe,
> struct seq_file *sf);
>
> /* component APIs */
> +extern __printf(10, 11)
Took me a while to understand this and found this link very helpful :) :-
https://www.avrfreaks.net/forum/gnuprintf-format-attribute
Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com>
> struct komeda_component *
> komeda_component_add(struct komeda_pipeline *pipe,
> size_t comp_sz, u32 id, u32 hw_id,
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-22 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 11:08 [PATCH] drm/komeda: Clean warning 'komeda_component_add' might be a candidate for 'gnu_printf' james qian wang (Arm Technology China)
2019-08-22 10:27 ` Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).