From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1549CC32750 for ; Tue, 13 Aug 2019 13:06:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF81A216F4 for ; Tue, 13 Aug 2019 13:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWi6khMG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbfHMNGf (ORCPT ); Tue, 13 Aug 2019 09:06:35 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:44540 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbfHMNGf (ORCPT ); Tue, 13 Aug 2019 09:06:35 -0400 Received: by mail-qk1-f194.google.com with SMTP id d79so79456110qke.11; Tue, 13 Aug 2019 06:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dPePM4b7Ly9h58EwlKTM619AD4xFQbyhPDiSia2EM2U=; b=rWi6khMGtrbzvWBFMuKOaneDwVBFkNzEA+bV4ShPlu9hL6T+L7nBa8gQDqbg7wmj9l A3KIk979T6sWVsHhW4Fm/VaENm/Pi3YN9D3TaMbA39C3bNT0UdMZbtzfgFwX8I773l/c 3RsG9coxViRKwz3yQGebHYpzOEt6b6aR6vvSzsRAH3RbtDY1HDGaMX6ehk0FlP7sff7C ekZDrrVWdki+9s23mAN9i+bmtgZqgXojixJSkXBwq8Efoir2sZDaba3uPvCZhlRSyqIY CrG+1B1yVaV4pE4euqUVZufBvyCGY3HP9VT9vlaNLTbPJwVsmhEc0FPeovlP8bvtYcsV nWyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=dPePM4b7Ly9h58EwlKTM619AD4xFQbyhPDiSia2EM2U=; b=sjVgoJtOQC6LV+GCYC11N4l2aclNgYcrqCvAdkhufO6a3AYQ1uExjDwGrn6jT4f6AG FhjL+r3DalA2bOG7t70aVNbk0COJhCAZTMBo1ysA1w0AFxsOQfl87IY7JKcfR8LNyE6X VvEDQMWmnDKFyI0i2jZewY1+l1Q0kzub5Rs7ivKjSVehI2O1eiAMZIceA2ipfh9vB0C1 yd9yI+eb9Pu/g7Lq3Yz2m46LvToLNLK+xbjvif36FqlFnwJBB4TzZhYTVpdAiaYjMU33 It0UdwWmUPCICUASMh4pbuFo12z3dlCZHbPD/xnJCuV6FzBrEfe4c7xgElPufyiOM5bH k4LA== X-Gm-Message-State: APjAAAUnKz4nQU3KhT1fFj92bBKR7HHzUHnUKz+4qHyEieXd2SI+zxVp zmwxbg0GQSKw7fhFOJ0NBmU= X-Google-Smtp-Source: APXvYqxoPh7Vwka4FMUE4K0pxkSvpnkQ2+EVcB3voDPInyDih0g+8JHM7XendeivsUYRonHZ4s/q+w== X-Received: by 2002:ae9:c00c:: with SMTP id u12mr23656206qkk.75.1565701594164; Tue, 13 Aug 2019 06:06:34 -0700 (PDT) Received: from localhost (tripoint.kitware.com. [66.194.253.20]) by smtp.gmail.com with ESMTPSA id z5sm45834363qti.80.2019.08.13.06.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 06:06:33 -0700 (PDT) Date: Tue, 13 Aug 2019 09:06:33 -0400 From: Ben Boeckel To: Alison Schofield Cc: "Kirill A. Shutemov" , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , David Howells , Kees Cook , Dave Hansen , Kai Huang , Jacob Pan , linux-mm@kvack.org, kvm@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload Message-ID: <20190813130633.GB9079@rotor.kitware.com> Reply-To: mathstuf@gmail.com References: <20190731150813.26289-1-kirill.shutemov@linux.intel.com> <20190731150813.26289-26-kirill.shutemov@linux.intel.com> <20190805115819.GA31656@rotor> <20190805203102.GA7592@alison-desk.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190805203102.GA7592@alison-desk.jf.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 13:31:02 -0700, Alison Schofield wrote: > It's not currently checked, but should be. > I'll add it as shown above. > Thanks for the review, Thanks. Seeing how this works elsewhere now, feel free to add my review with the proposed check to the new patch. Reviewed-by: Ben Boeckel --Ben