linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: kbuild-all@01.org, nitesh@redhat.com, kvm@vger.kernel.org,
	mst@redhat.com, david@redhat.com, dave.hansen@intel.com,
	linux-kernel@vger.kernel.org, willy@infradead.org,
	mhocko@kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org,
	virtio-dev@lists.oasis-open.org, osalvador@suse.de,
	yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com,
	konrad.wilk@oracle.com, lcapitulino@redhat.com,
	wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com
Subject: Re: [PATCH v5 4/6] mm: Introduce Reported pages
Date: Tue, 13 Aug 2019 16:34:57 +0800	[thread overview]
Message-ID: <201908131650.yQgS9S59%lkp@intel.com> (raw)
In-Reply-To: <20190812213344.22097.86213.stgit@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 13178 bytes --]

Hi Alexander,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alexander-Duyck/mm-virtio-Provide-support-for-unused-page-reporting/20190813-150543
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

    
   In file included from include/linux/thread_info.h:38:0,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/thread_info.h:9:0: note: this is the location of the previous definition
    #define THREAD_SIZE_ORDER CONFIG_KERNEL_STACK_ORDER
    
   In file included from arch/x86/include/asm/page_types.h:48:0,
                    from arch/x86/include/asm/pgtable_types.h:8,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/page_64_types.h:16:0: warning: "THREAD_SIZE" redefined
    #define THREAD_SIZE  (PAGE_SIZE << THREAD_SIZE_ORDER)
    
   In file included from include/linux/thread_info.h:38:0,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/thread_info.h:10:0: note: this is the location of the previous definition
    #define THREAD_SIZE ((1 << CONFIG_KERNEL_STACK_ORDER) * PAGE_SIZE)
    
   In file included from arch/x86/include/asm/pgtable_types.h:249:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_64_types.h:21:34: error: conflicting types for 'pte_t'
    typedef struct { pteval_t pte; } pte_t;
                                     ^~~~~
   In file included from arch/um/include/asm/thread_info.h:15:0,
                    from include/linux/thread_info.h:38,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/page.h:57:39: note: previous declaration of 'pte_t' was here
    typedef struct { unsigned long pte; } pte_t;
                                          ^~~~~
   In file included from include/linux/page_reporting.h:8:0,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_types.h:265:47: error: conflicting types for 'pgprot_t'
    typedef struct pgprot { pgprotval_t pgprot; } pgprot_t;
                                                  ^~~~~~~~
   In file included from arch/um/include/asm/thread_info.h:15:0,
                    from include/linux/thread_info.h:38,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/page.h:80:42: note: previous declaration of 'pgprot_t' was here
    typedef struct { unsigned long pgprot; } pgprot_t;
                                             ^~~~~~~~
   In file included from include/linux/page_reporting.h:8:0,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_types.h:267:34: error: conflicting types for 'pgd_t'
    typedef struct { pgdval_t pgd; } pgd_t;
                                     ^~~~~
   In file included from arch/um/include/asm/thread_info.h:15:0,
                    from include/linux/thread_info.h:38,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/page.h:58:39: note: previous declaration of 'pgd_t' was here
    typedef struct { unsigned long pgd; } pgd_t;
                                          ^~~~~
   In file included from arch/x86/include/asm/pgtable_types.h:346:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
>> include/asm-generic/pgtable-nopud.h:21:0: warning: "PUD_SHIFT" redefined
    #define PUD_SHIFT P4D_SHIFT
    
   In file included from arch/x86/include/asm/pgtable_types.h:249:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_64_types.h:83:0: note: this is the location of the previous definition
    #define PUD_SHIFT 30
    
   In file included from arch/x86/include/asm/pgtable_types.h:346:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
>> include/asm-generic/pgtable-nopud.h:22:0: warning: "PTRS_PER_PUD" redefined
    #define PTRS_PER_PUD 1
    
   In file included from arch/x86/include/asm/pgtable_types.h:249:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_64_types.h:84:0: note: this is the location of the previous definition
    #define PTRS_PER_PUD 512
    
   In file included from arch/x86/include/asm/pgtable_types.h:346:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
>> include/asm-generic/pgtable-nopud.h:23:0: warning: "PUD_SIZE" redefined
    #define PUD_SIZE   (1UL << PUD_SHIFT)
    
   In file included from arch/x86/include/asm/pgtable_types.h:249:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_64_types.h:100:0: note: this is the location of the previous definition
    #define PUD_SIZE (_AC(1, UL) << PUD_SHIFT)
    
   In file included from arch/x86/include/asm/pgtable_types.h:346:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
>> include/asm-generic/pgtable-nopud.h:24:0: warning: "PUD_MASK" redefined
    #define PUD_MASK   (~(PUD_SIZE-1))
    
   In file included from arch/x86/include/asm/pgtable_types.h:249:0,
                    from include/linux/page_reporting.h:8,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_64_types.h:101:0: note: this is the location of the previous definition
    #define PUD_MASK (~(PUD_SIZE - 1))
    
   In file included from include/linux/page_reporting.h:8:0,
                    from include/linux/mmzone.h:774,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:19,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:5,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/x86/include/asm/pgtable_types.h:360:34: error: conflicting types for 'pmd_t'
    typedef struct { pmdval_t pmd; } pmd_t;
                                     ^~~~~
   In file included from arch/um/include/asm/thread_info.h:15:0,
                    from include/linux/thread_info.h:38,
                    from include/asm-generic/current.h:5,
                    from ./arch/um/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from arch/x86/um/shared/sysdep/kernel-offsets.h:3,
                    from arch/um/kernel/asm-offsets.c:1:
   arch/um/include/asm/page.h:61:39: note: previous declaration of 'pmd_t' was here
    typedef struct { unsigned long pmd; } pmd_t;
                                          ^~~~~
   make[2]: *** [arch/um/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   4 real  4 user  2 sys  157.04% cpu 	make prepare

vim +/PUD_SHIFT +21 include/asm-generic/pgtable-nopud.h

^1da177e4c3f41 Linus Torvalds     2005-04-16  20  
048456dcf2c56a Kirill A. Shutemov 2017-03-09 @21  #define PUD_SHIFT	P4D_SHIFT
^1da177e4c3f41 Linus Torvalds     2005-04-16 @22  #define PTRS_PER_PUD	1
^1da177e4c3f41 Linus Torvalds     2005-04-16 @23  #define PUD_SIZE  	(1UL << PUD_SHIFT)
^1da177e4c3f41 Linus Torvalds     2005-04-16 @24  #define PUD_MASK  	(~(PUD_SIZE-1))
^1da177e4c3f41 Linus Torvalds     2005-04-16  25  

:::::: The code at line 21 was first introduced by commit
:::::: 048456dcf2c56ad6f6248e2899dda92fb6a613f6 asm-generic: introduce <asm-generic/pgtable-nop4d.h>

:::::: TO: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8307 bytes --]

  parent reply	other threads:[~2019-08-13  8:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 21:33 [PATCH v5 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-08-12 21:33 ` [PATCH v5 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-08-12 22:24   ` Dan Williams
2019-08-12 22:49     ` Alexander Duyck
2019-08-12 21:33 ` [PATCH v5 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-08-12 21:33 ` [PATCH v5 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-08-12 22:39   ` Dan Williams
2019-08-12 21:33 ` [PATCH v5 4/6] mm: Introduce Reported pages Alexander Duyck
2019-08-13  8:07   ` David Hildenbrand
2019-08-13 17:35     ` Alexander Duyck
2019-08-14 12:57       ` David Hildenbrand
2019-08-13  8:34   ` kbuild test robot [this message]
2019-08-13  8:39   ` kbuild test robot
2019-08-12 21:33 ` [PATCH v5 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-08-12 21:33 ` [PATCH v5 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-09-03  7:32   ` Michael S. Tsirkin
2019-09-03 14:13     ` Alexander Duyck
2019-09-04 10:44       ` Michael S. Tsirkin
2019-09-04 14:23         ` Alexander Duyck
2019-08-12 21:34 ` [PATCH v5 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-08-12 21:34 ` [PATCH v5 QEMU 2/3] virtio-balloon: Add bit to notify guest of unused page reporting Alexander Duyck
2019-08-12 21:34 ` [PATCH v5 QEMU 3/3] virtio-balloon: Provide a interface for " Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201908131650.yQgS9S59%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nitesh@redhat.com \
    --cc=osalvador@suse.de \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=riel@surriel.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wei.w.wang@intel.com \
    --cc=willy@infradead.org \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).