* [PATCH] cxgb4: fix a memory leak bug
@ 2019-08-13 9:18 Wenwen Wang
2019-08-15 3:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wenwen Wang @ 2019-08-13 9:18 UTC (permalink / raw)
To: Wenwen Wang
Cc: Vishal Kulkarni, David S. Miller,
open list:CXGB4 ETHERNET DRIVER (CXGB4),
open list
In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails,
leading to a memory leak bug. To fix this issue, free t before returning
the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 0295903..d692251 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -3236,8 +3236,10 @@ static ssize_t blocked_fl_write(struct file *filp, const char __user *ubuf,
return -ENOMEM;
err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz);
- if (err)
+ if (err) {
+ kvfree(t);
return err;
+ }
bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz);
kvfree(t);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb4: fix a memory leak bug
2019-08-13 9:18 [PATCH] cxgb4: fix a memory leak bug Wenwen Wang
@ 2019-08-15 3:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-08-15 3:03 UTC (permalink / raw)
To: wenwen; +Cc: vishal, netdev, linux-kernel
From: Wenwen Wang <wenwen@cs.uga.edu>
Date: Tue, 13 Aug 2019 04:18:52 -0500
> In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails,
> leading to a memory leak bug. To fix this issue, free t before returning
> the error.
>
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-15 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 9:18 [PATCH] cxgb4: fix a memory leak bug Wenwen Wang
2019-08-15 3:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).