From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB800C0650F for ; Wed, 14 Aug 2019 05:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C68F020843 for ; Wed, 14 Aug 2019 05:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565761241; bh=BcTVOpWjejlJQLRKMOuwLxgamclM2LKtYDZAFC7tU0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yJrz5eu8M0Go8/9d2nfHzcZuOVbQ3xS1uByquOEb0K5soQR5TqtJHE+xn3WkOevvd uGSWqUeN4l1CtMTaj3V0JgI6GQcQyAKxVhDrv6imy5uidEHxFpIX62liSIvSyNxuo4 kdpW5jgR4YRuzf1xKSpZPr0RUI6eLckbfgacUdg0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbfHNFkk (ORCPT ); Wed, 14 Aug 2019 01:40:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:60836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726882AbfHNFkk (ORCPT ); Wed, 14 Aug 2019 01:40:40 -0400 Received: from localhost (c-73-15-1-175.hsd1.ca.comcast.net [73.15.1.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F3B120843; Wed, 14 Aug 2019 05:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565761239; bh=BcTVOpWjejlJQLRKMOuwLxgamclM2LKtYDZAFC7tU0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EMzCqMDBjkofqdOZx59ict1Fr6TMdqw0s4RuTCigOU3/xywNMLDhFt/E1awRwhuyH uZLmCsD58zb1pfz1g2Ya3zLjA6sl+alQU9UVYjLYzSovK6pEHohGXcB58juvbRNMqS p35vDmmxYK6fDlwB4gNiGKRYkRG5S3pVk5mBODfY= Date: Wed, 14 Aug 2019 00:40:38 -0500 From: Bjorn Helgaas To: Kelsey Skunberg Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Greg Kroah-Hartman Subject: Re: [Linux-kernel-mentees] [PATCH v2 0/3] PCI: pci-sysfs.c cleanup Message-ID: <20190814054038.GB253360@google.com> References: <20190809195721.34237-1-skunberg.kelsey@gmail.com> <20190813204513.4790-1-skunberg.kelsey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813204513.4790-1-skunberg.kelsey@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Greg] On Tue, Aug 13, 2019 at 02:45:10PM -0600, Kelsey Skunberg wrote: > This series is designed to clean up device attributes and permissions in > pci-sysfs.c. Then move the sysfs SR-IOV functions from pci-sysfs.c to > iov.c for better organization. Patches build off of each other. > > Patch 1: Define device attributes with DEVICE_ATTR*() instead of __ATTR*(). > > Patch 2: Change permissions from symbolic to the preferred octal. > > Patch 3: Move sysfs SR-IOV functions to iov.c to keep the feature's code > together. > > Changes since v1: > Add patch 1 and 2 to fix the way device attributes are defined > and change permissions from symbolic to octal. Patch 3 which moves > sysfs SR-IOV functions to iov.c will then apply cleaner. > > > Kelsey Skunberg (3): > PCI: sysfs: Define device attributes with DEVICE_ATTR*() > PCI: sysfs: Change permissions from symbolic to octal > PCI/IOV: Move sysfs SR-IOV functions to iov.c > > drivers/pci/iov.c | 168 +++++++++++++++++++++++++++++++ > drivers/pci/pci-sysfs.c | 217 ++++------------------------------------ > drivers/pci/pci.h | 2 +- > 3 files changed, 188 insertions(+), 199 deletions(-) Applied to pci/virtualization for v5.4, thanks! Beginning of thread: https://lore.kernel.org/r/20190813204513.4790-1-skunberg.kelsey@gmail.com