From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D04C32757 for ; Wed, 14 Aug 2019 11:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48F07206C2 for ; Wed, 14 Aug 2019 11:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbfHNLkQ convert rfc822-to-8bit (ORCPT ); Wed, 14 Aug 2019 07:40:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:41962 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727083AbfHNLkP (ORCPT ); Wed, 14 Aug 2019 07:40:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E115BAE5C; Wed, 14 Aug 2019 11:40:13 +0000 (UTC) Date: Wed, 14 Aug 2019 13:40:12 +0200 From: Thomas Bogendoerfer To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: Greg Kroah-Hartman , Andy Shevchenko , Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Jiri Slaby , Evgeniy Polyakov , linux-mips@vger.kernel.org, Linux Kernel Mailing List , linux-input , netdev , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:SERIAL DRIVERS" Subject: Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing Message-Id: <20190814134012.0a1793598a478b55f6361924@suse.de> In-Reply-To: <90129235-58c2-aeed-a9d3-96f4a8f45709@amsat.org> References: <20190809103235.16338-1-tbogendoerfer@suse.de> <20190809103235.16338-9-tbogendoerfer@suse.de> <20190811072907.GA1416@kroah.com> <90129235-58c2-aeed-a9d3-96f4a8f45709@amsat.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Aug 2019 10:47:13 +0200 Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 8/11/19 9:29 AM, Greg Kroah-Hartman wrote: > > On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: > >> On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer > >> wrote: > >>> > >>> Our chosen byte swapping, which is what firmware already uses, is to > >>> do readl/writel by normal lw/sw intructions (data invariance). This > >>> also means we need to mangle addresses for u8 and u16 accesses. The > >>> mangling for 16bit has been done aready, but 8bit one was missing. > >>> Correcting this causes different addresses for accesses to the > >>> SuperIO and local bus of the IOC3 chip. This is fixed by changing > >>> byte order in ioc3 and m48rtc_rtc structs. > >> > >>> /* serial port register map */ > >>> struct ioc3_serialregs { > >>> - uint32_t sscr; > >>> - uint32_t stpir; > >>> - uint32_t stcir; > >>> - uint32_t srpir; > >>> - uint32_t srcir; > >>> - uint32_t srtr; > >>> - uint32_t shadow; > >>> + u32 sscr; > >>> + u32 stpir; > >>> + u32 stcir; > >>> + u32 srpir; > >>> + u32 srcir; > >>> + u32 srtr; > >>> + u32 shadow; > >>> }; > >> > >> Isn't it a churn? AFAIU kernel documentation the uint32_t is okay to > >> use, just be consistent inside one module / driver. > >> Am I mistaken? > > > > No, but really it uint* shouldn't be used anywhere in the kernel source > > as it does not make sense. > > If you respin your series, please send this cleanup as a separate patch. no need for an extra patch. I realized that patch 7 in this series introduces all of these uint32_t. So i already fixed it there. Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)