From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA638C32753 for ; Wed, 14 Aug 2019 17:14:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FF6A2133F for ; Wed, 14 Aug 2019 17:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802879; bh=JDqGp7ficmkhH3OHfXmiMvWvv77TF/w7o7o0AB9EMSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=K1YxCUMVeI2s/dfve+K6+cB0VM8ACZngDjMPTDPM/2iW7UTapDInfi9w0Ltlgw+dZ tI9ujGhwoYPDHcWCl2pJY10sqwTVRrg1nNreD2Y2Wwy6F+HH0VIO0+usUOb5oGWvbx tidgPoGg3dVjIWdfZ6bUCZpYqJKAG/j0iBs++Shc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731114AbfHNROi (ORCPT ); Wed, 14 Aug 2019 13:14:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:39074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729485AbfHNROe (ORCPT ); Wed, 14 Aug 2019 13:14:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E1662133F; Wed, 14 Aug 2019 17:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802874; bh=JDqGp7ficmkhH3OHfXmiMvWvv77TF/w7o7o0AB9EMSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bLQ4R8AznmozEMUHu6rQIT1BxVnU7mI3GbD6M04H+EfBgNUsHF4W41oU/mMAopZwY /Uk3Re2mhFIGuENnoqj9gx2ZYW5b5CXZz/KfBQC0fhqJeHcOZqRIEfDu6tnQ9TLHrd hgpInMSfP4J4gQgcglcs0mnSfADELm31jHJ4GXww= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Shilovsky , Steve French , Ronnie Sahlberg Subject: [PATCH 4.14 60/69] SMB3: Fix deadlock in validate negotiate hits reconnect Date: Wed, 14 Aug 2019 19:01:58 +0200 Message-Id: <20190814165749.957581495@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165744.822314328@linuxfoundation.org> References: <20190814165744.822314328@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Shilovsky commit e99c63e4d86d3a94818693147b469fa70de6f945 upstream. Currently we skip SMB2_TREE_CONNECT command when checking during reconnect because Tree Connect happens when establishing an SMB session. For SMB 3.0 protocol version the code also calls validate negotiate which results in SMB2_IOCL command being sent over the wire. This may deadlock on trying to acquire a mutex when checking for reconnect. Fix this by skipping SMB2_IOCL command when doing the reconnect check. Signed-off-by: Pavel Shilovsky Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg CC: Stable Signed-off-by: Greg Kroah-Hartman --- fs/cifs/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -166,7 +166,7 @@ smb2_reconnect(__le16 smb2_command, stru if (tcon == NULL) return 0; - if (smb2_command == SMB2_TREE_CONNECT) + if (smb2_command == SMB2_TREE_CONNECT || smb2_command == SMB2_IOCTL) return 0; if (tcon->tidStatus == CifsExiting) {