From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DFDC433FF for ; Wed, 14 Aug 2019 17:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0448214DA for ; Wed, 14 Aug 2019 17:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802221; bh=CoPGPtaIX+GCfu6wF7OH5MxGzuQJ7Y8ZXc/iPospVPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ly5uWn82B1/7oI7bzzgMq+cVH+pf0dEpmKHQyKTlBwKI229edBVlUFhYiF+gUEc7U CRVlWnIBs/rPugNAZiTp9xLPR7kcWu9d6VqY774oi17HE9m4mfZtaQA9VuvolfDV3K MiRgP+u8x0eLRrhfLUCHi94rpJU2nweDGRjisiwU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728994AbfHNRDk (ORCPT ); Wed, 14 Aug 2019 13:03:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:52292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728420AbfHNRDi (ORCPT ); Wed, 14 Aug 2019 13:03:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1656F214DA; Wed, 14 Aug 2019 17:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802217; bh=CoPGPtaIX+GCfu6wF7OH5MxGzuQJ7Y8ZXc/iPospVPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qcf3OPVlCisTP2ilgQmg4eRq9JQkbB+dmtHL2IBtbEiVxNyMbfeiwDn3sRxrl1FX0 4o3jfhdOV/QE+TQSaRfjvWuNb91g0CKy630WWlKHQQJmu5f4FdSXD9Bz1Mj3+MAflA QabmDGdeheijwWKH0NtgZC0QLywonqWwPkczt+dg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kbuild test robot , Heikki Krogerus Subject: [PATCH 5.2 040/144] usb: typec: ucsi: ccg: Fix uninitilized symbol error Date: Wed, 14 Aug 2019 18:59:56 +0200 Message-Id: <20190814165801.510168506@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165759.466811854@linuxfoundation.org> References: <20190814165759.466811854@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heikki Krogerus commit a29d56c2ed24ad33062bfdafdec9e34149715320 upstream. Fix smatch error: drivers/usb/typec/ucsi/ucsi_ccg.c:975 ccg_fw_update() error: uninitialized symbol 'err'. Fixes: 5c9ae5a87573 ("usb: typec: ucsi: ccg: add firmware flashing support") Cc: stable@vger.kernel.org Reported-by: kbuild test robot Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20190801075512.24354-1-heikki.krogerus@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/typec/ucsi/ucsi_ccg.c +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c @@ -963,7 +963,7 @@ release_fw: ******************************************************************************/ static int ccg_fw_update(struct ucsi_ccg *uc, enum enum_flash_mode flash_mode) { - int err; + int err = 0; while (flash_mode != FLASH_NOT_NEEDED) { err = do_flash(uc, flash_mode);