From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D89DC433FF for ; Wed, 14 Aug 2019 17:08:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F0B0214DA for ; Wed, 14 Aug 2019 17:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802500; bh=8kfYVqb2NIlKpHyB9OJtszlE9DT2CdhMlAunHr6PX7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JhSfkpRT5FUO52yQdZQaPBv6icX2TNbgwiwXdWw4Cxk/wlzLZflIhsFxUnSRJ1Ik9 a14t9NUmONoGEzHGnrf0MlHYirN8rTmjhkdE34leZR77hbRfUS9n61dhbU5p6m8Ffu TnRDhSlbP2eefswbop2rZG9XzS1eoTAxTll+t7jc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730120AbfHNRIT (ORCPT ); Wed, 14 Aug 2019 13:08:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730102AbfHNRIQ (ORCPT ); Wed, 14 Aug 2019 13:08:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E8ED214DA; Wed, 14 Aug 2019 17:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802495; bh=8kfYVqb2NIlKpHyB9OJtszlE9DT2CdhMlAunHr6PX7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KZxGlhp8FF3+X8dENU+OrA8Kmb/mUYcJdOoev/FenMAU243CJXZW9S1G81jDf8bk1 sLcYDpDvdu5+dd22qHonP5B+iqqWEELM7Y5keIWjXkPFHStRKPC97Jvid1eUcjreZS 8r0VjVFaTQ6Gu2HzeOY60KIj9RXhOsDkshmrz2Vg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomas Bortoli , syzbot+513e4d0985298538bf9b@syzkaller.appspotmail.com, Marc Kleine-Budde Subject: [PATCH 5.2 122/144] can: peak_usb: pcan_usb_fd: Fix info-leaks to USB devices Date: Wed, 14 Aug 2019 19:01:18 +0200 Message-Id: <20190814165805.033851424@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165759.466811854@linuxfoundation.org> References: <20190814165759.466811854@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomas Bortoli commit 30a8beeb3042f49d0537b7050fd21b490166a3d9 upstream. Uninitialized Kernel memory can leak to USB devices. Fix by using kzalloc() instead of kmalloc() on the affected buffers. Signed-off-by: Tomas Bortoli Reported-by: syzbot+513e4d0985298538bf9b@syzkaller.appspotmail.com Fixes: 0a25e1f4f185 ("can: peak_usb: add support for PEAK new CANFD USB adapters") Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c @@ -841,7 +841,7 @@ static int pcan_usb_fd_init(struct peak_ goto err_out; /* allocate command buffer once for all for the interface */ - pdev->cmd_buffer_addr = kmalloc(PCAN_UFD_CMD_BUFFER_SIZE, + pdev->cmd_buffer_addr = kzalloc(PCAN_UFD_CMD_BUFFER_SIZE, GFP_KERNEL); if (!pdev->cmd_buffer_addr) goto err_out_1;