From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2ACBC32753 for ; Wed, 14 Aug 2019 17:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE015208C2 for ; Wed, 14 Aug 2019 17:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802066; bh=Vh+lga1zBJdv/7/3pj4v8unidtWcvcdce5+7GazS3nI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=a6NlwXGgs3skhY3ClqW6EgsbsZzlIYYkA1WRLpSleicK62jQVMeU88SJHhjw9K6T9 s9iOYr8V5xPoNWfugKCo2CDe1VLXntJkDmftVUVppEUWOSXeT/Ff1l26Nil4igyeJs KHsjEPyveHlppAiVAx6scb/bcl5Ma+XYlASK3yFo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728431AbfHNRBG (ORCPT ); Wed, 14 Aug 2019 13:01:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:50258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728329AbfHNRBF (ORCPT ); Wed, 14 Aug 2019 13:01:05 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 027C42063F; Wed, 14 Aug 2019 17:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802065; bh=Vh+lga1zBJdv/7/3pj4v8unidtWcvcdce5+7GazS3nI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Pn7XS1QqYeCxlgbOHi0Q2V295J2Yw83V6M52HLgvD/biAQ3DLRmelp6urX9rHWdEO 5o3Vl2vKK7TWeCpC4Um/i4GXA8dkMLnGGTNMlKmq86wrfd5grVeDFRWbPnmixISTpF 5kUVGZizZp/IyKfvKQyKp3dJPi7v1NF5FPkwKU94= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190814125012.8700-4-vkoul@kernel.org> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-4-vkoul@kernel.org> Subject: Re: [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org To: Andy Gross , Vinod Koul User-Agent: alot/0.8.1 Date: Wed, 14 Aug 2019 10:01:04 -0700 Message-Id: <20190814170105.027C42063F@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Vinod Koul (2019-08-14 05:49:53) > Signed-off-by: Vinod Koul > --- Add some commit text? Or just squash with the first patch? Not sure why it's a different commit. > arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/q= com/sm8150.dtsi > index cd9fcadaeacb..5f2f21270e2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -189,6 +189,21 @@ > }; > }; > =20 > + tlmm: pinctrl@3100000 { > + compatible =3D "qcom,sm8150-pinctrl"; > + reg =3D <0x03100000 0x300000>, > + <0x03500000 0x300000>, > + <0x03900000 0x300000>, > + <0x03D00000 0x300000>; Please don't use capitalized hex characters. > + reg-names =3D "west", "east", "north", "south"; > + interrupts =3D ; > + gpio-ranges =3D <&tlmm 0 0 175>; > + gpio-controller; > + #gpio-cells =3D <2>; > + interrupt-controller; > + #interrupt-cells =3D <2>; > + }; > +