Re: [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node

From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	sibis@codeaurora.org, Vinod Koul <vkoul@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/22] arm64: dts: qcom: pm8150: Add vadc node
Date: Wed, 14 Aug 2019 10:05:17 -0700	[thread overview]
Message-ID: <20190814170518.9D0EB2084D@mail.kernel.org> (raw)
In-Reply-To: <20190814125012.8700-9-vkoul@kernel.org>

Quoting Vinod Koul (2019-08-14 05:49:58)
> @@ -25,6 +26,33 @@
>                         };
>                 };
>  
> +               pm8150_adc: adc@3100 {
> +                       compatible = "qcom,spmi-adc5";
> +                       reg = <0x3100>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       #io-channel-cells = <1>;
> +                       interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;

status = "disabled"? I imagine there are cases where some board doesn't
want to use the ADC for anything.

> +
> +                       ref-gnd@0 {
> +                               reg = <ADC5_REF_GND>;
> +                               qcom,pre-scaling = <1 1>;
> +                               label = "ref_gnd";
> +                       };
> +
> +                       vref-1p25@1 {
> +                               reg = <ADC5_1P25VREF>;
> +                               qcom,pre-scaling = <1 1>;
> +                               label = "vref_1p25";
> +                       };
> +
> +                       die-temp@6 {
> +                               reg = <ADC5_DIE_TEMP>;
> +                               qcom,pre-scaling = <1 1>;
> +                               label = "die_temp";
> +                       };

Are these board level details?

> +               };
> +
>                 rtc@6000 {
>                         compatible = "qcom,pm8941-rtc";
>                         reg = <0x6000>;
> -- 
> 2.20.1
> 