From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA68C32753 for ; Wed, 14 Aug 2019 18:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B913920651 for ; Wed, 14 Aug 2019 18:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="txtm+14G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728731AbfHNSAn (ORCPT ); Wed, 14 Aug 2019 14:00:43 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:44773 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbfHNSAn (ORCPT ); Wed, 14 Aug 2019 14:00:43 -0400 Received: by mail-pf1-f193.google.com with SMTP id c81so5015856pfc.11 for ; Wed, 14 Aug 2019 11:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dOMdAe6AqeWQZHyQVAAMCKAQHRACwZHKY6wC0SFV1+U=; b=txtm+14GF2FCSoDvBp13P47mYXIYr8VsHkaLQ9+qzdynxVrPmEdrI3/VF89cQ40aHO oxgSbC3sqrQqx4xtNgEWud9V7Y4Dwtgcs6TVrtMZcHWviQjqMfZK0m7rwk7t1BmWhL7L jWgqAFWfDcXmgPVogpvNZ1QoXmGGaF/uugJYIukTmXWp8cMQSuxBrfSLITM80ysXXMT3 oWiTb+hlXjbV3rib2xR5s/FAWi4i3cAD/CvYQEfnRmwJ2sSeajSsXWxylBCiLmiZ4aPT c1/PlQHMFj3pkkIDK6pLYs3vrH9UYO5JkL3zkEzOVg8YFl/aVm51r/jjD2V+EuNOMKgA PQhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dOMdAe6AqeWQZHyQVAAMCKAQHRACwZHKY6wC0SFV1+U=; b=UVq1Wo+zav8mHsEDtFsxOzP2qEthpxxtsenDvPxY694qTF7Zg41o+ip9EYgqhqNEQ4 CC1Ks5MYHO4TlPncojYPcPyGNbln8kbtRKfcDoFiXbSfT3rBTQElVAgDQ1ZYSMGSYeye eJvrDRN0SDg+P+z/LtgXwl65/SwZf8NT5E1W4MdymTxME5Amj2pkA2P7uki8Hro+wFDX q6eag/Dw7iPcDBaCKOwhZbPPMcb/ocVlQSXaPj8hciYekqdo6sSe0T7w481MnOuU8f1L WJTX1xREvuIvauu1nBUhBjciB2gGEPZfdwBGF71JFUBV8PKWySzQ+NjrZOYBeOthT8Qj GmRQ== X-Gm-Message-State: APjAAAXwlx689DVtWj+fDk4ONNSAF9Gtlzo5NkTF0r7dZdO6rwxfx5TJ EDHjqs1lkvqF63/op1OAJFhH4Ds4 X-Google-Smtp-Source: APXvYqwQ2VCcn8bkJMBj4iGZSuOaB8ioPvLpamL0svo5YO/TVOQJzbQnplGw8s1N9sXKwpH97HUlUA== X-Received: by 2002:a17:90a:fe01:: with SMTP id ck1mr866293pjb.89.1565805642428; Wed, 14 Aug 2019 11:00:42 -0700 (PDT) Received: from bharath12345-Inspiron-5559 ([103.110.42.36]) by smtp.gmail.com with ESMTPSA id x25sm527942pfa.90.2019.08.14.11.00.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 11:00:41 -0700 (PDT) Date: Wed, 14 Aug 2019 23:30:31 +0530 From: Bharath Vedartham To: Jason Gunthorpe Cc: Dimitri Sivanich , jhubbard@nvidia.com, gregkh@linuxfoundation.org, arnd@arndb.de, ira.weiny@intel.com, jglisse@redhat.com, william.kucharski@oracle.com, hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees][PATCH v5 1/1] sgi-gru: Remove *pte_lookup functions, Convert to get_user_page*() Message-ID: <20190814180031.GB5121@bharath12345-Inspiron-5559> References: <1565379497-29266-1-git-send-email-linux.bhar@gmail.com> <1565379497-29266-2-git-send-email-linux.bhar@gmail.com> <20190813145029.GA32451@hpe.com> <20190813172301.GA10228@bharath12345-Inspiron-5559> <20190813181938.GA4196@hpe.com> <20190814173034.GA5121@bharath12345-Inspiron-5559> <20190814173830.GC13770@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814173830.GC13770@ziepe.ca> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 02:38:30PM -0300, Jason Gunthorpe wrote: > On Wed, Aug 14, 2019 at 11:00:34PM +0530, Bharath Vedartham wrote: > > On Tue, Aug 13, 2019 at 01:19:38PM -0500, Dimitri Sivanich wrote: > > > On Tue, Aug 13, 2019 at 10:53:01PM +0530, Bharath Vedartham wrote: > > > > On Tue, Aug 13, 2019 at 09:50:29AM -0500, Dimitri Sivanich wrote: > > > > > Bharath, > > > > > > > > > > I do not believe that __get_user_pages_fast will work for the atomic case, as > > > > > there is no guarantee that the 'current->mm' will be the correct one for the > > > > > process in question, as the process might have moved away from the cpu that is > > > > > handling interrupts for it's context. > > > > So what your saying is, there may be cases where current->mm != gts->ts_mm > > > > right? __get_user_pages_fast and get_user_pages do assume current->mm. > > > > > > Correct, in the case of atomic context. > > > > > > > > > > > These changes were inspired a bit from kvm. In kvm/kvm_main.c, > > > > hva_to_pfn_fast uses __get_user_pages_fast. THe comment above the > > > > function states it runs in atomic context. > > > > > > > > Just curious, get_user_pages also uses current->mm. Do you think that is > > > > also an issue? > > > > > > Not in non-atomic context. Notice that it is currently done that way. > > > > > > > > > > > Do you feel using get_user_pages_remote would be a better idea? We can > > > > specify the mm_struct in get_user_pages_remote? > > > > > > From that standpoint maybe, but is it safe in interrupt context? > > Hmm.. The gup maintainers seemed fine with the code.. > > > > Now this is only an issue if gru_vtop can be executed in an interrupt > > context. > > > > get_user_pages_remote is not valid in an interrupt context(if CONFIG_MMU > > is set). If we follow the function, in __get_user_pages, cond_resched() > > is called which definitly confirms that we can't run this function in an > > interrupt context. > > > > I think we might need some advice from the gup maintainers here. > > Note that the comment on the function __get_user_pages_fast states that > > __get_user_pages_fast is IRQ-safe. > > vhost is doing some approach where they switch current to the target > then call __get_user_pages_fast in an IRQ context, that might be a > reasonable pattern > > If this is a regular occurance we should probably add a > get_atomic_user_pages_remote() to make the pattern clear. > > Jason That makes sense. get_atomic_user_pages_remote() should not be hard to write. AFAIKS __get_user_pages_fast is special_cased for current, we could probably just add a new parameter of the mm_struct to the page table walking code in gup.c But till then I think we can approach this by the way vhost approaches this problem by switching current to the target. Thank you Bharath