From: Herbert Xu <herbert@gondor.apana.org.au>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] padata: always acquire cpu_hotplug_lock before pinst->lock
Date: Thu, 15 Aug 2019 15:15:18 +1000 [thread overview]
Message-ID: <20190815051518.GB24982@gondor.apana.org.au> (raw)
In-Reply-To: <20190809192857.26585-1-daniel.m.jordan@oracle.com>
On Fri, Aug 09, 2019 at 03:28:56PM -0400, Daniel Jordan wrote:
> On a 5.2 kernel, lockdep complains when offlining a CPU and writing to a
> parallel_cpumask sysfs file.
>
> echo 0 > /sys/devices/system/cpu/cpu1/online
> echo ff > /sys/kernel/pcrypt/pencrypt/parallel_cpumask
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.2.0-padata-base+ #19 Not tainted
> ------------------------------------------------------
> cpuhp/1/13 is trying to acquire lock:
> ... (&pinst->lock){+.+.}, at: padata_cpu_prep_down+0x37/0x70
>
> but task is already holding lock:
> ... (cpuhp_state-down){+.+.}, at: cpuhp_thread_fun+0x34/0x240
>
> which lock already depends on the new lock.
>
> padata doesn't take cpu_hotplug_lock and pinst->lock in a consistent
> order. Which should be first? CPU hotplug calls into padata with
> cpu_hotplug_lock already held, so it should have priority.
Yeah this is clearly a bug but I think we need tackle something
else first.
> diff --git a/kernel/padata.c b/kernel/padata.c
> index b60cc3dcee58..d056276a96ce 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -487,9 +487,7 @@ static void __padata_stop(struct padata_instance *pinst)
>
> synchronize_rcu();
>
> - get_online_cpus();
> padata_flush_queues(pinst->pd);
> - put_online_cpus();
> }
As I pointed earlier, the whole concept of flushing the queues is
suspect. So we should tackle that first and it may obviate the need
to do get_online_cpus completely if the flush call disappears.
My main worry is that you're adding an extra lock around synchronize_rcu
and that is always something that should be done only after careful
investigation.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-08-15 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 19:28 [PATCH 1/2] padata: always acquire cpu_hotplug_lock before pinst->lock Daniel Jordan
2019-08-09 19:28 ` [PATCH 2/2] padata: validate cpumask without removed CPU during offline Daniel Jordan
2019-08-09 21:06 ` [PATCH v2] " Daniel Jordan
2019-08-12 21:02 ` [PATCH 3/2] padata: initialize usable masks to reflect offlined CPU Daniel Jordan
2019-08-22 3:51 ` Herbert Xu
2019-08-22 22:11 ` Daniel Jordan
2019-08-22 3:50 ` [PATCH v2] padata: validate cpumask without removed CPU during offline Herbert Xu
2019-08-22 22:10 ` Daniel Jordan
2019-08-22 22:53 ` Daniel Jordan
2019-08-15 5:15 ` Herbert Xu [this message]
2019-08-21 4:14 ` [PATCH 1/2] padata: always acquire cpu_hotplug_lock before pinst->lock Daniel Jordan
2019-08-21 6:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815051518.GB24982@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).