From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B417C433FF for ; Thu, 15 Aug 2019 07:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FA002086C for ; Thu, 15 Aug 2019 07:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565853247; bh=WtivyFKRGxuuhoSsg/tkmBPj16Bi9q7VKN8kdDZDkCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gGTTVk3U9KX2ESonNrRBGT23R4Q6magsCJ65LamXyrtO2nE28AVE7c9HETd9tvSG7 puBXAFjCn6Xs17eQNXv2Q2N6K5cVtdmEJ+cdha1bVIo56gZ1U/dLsSF1KU/0s721pf TDA8vOy0oTA4gYfzzmCqwV6TSq00hxJlr8hJu5M0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730642AbfHOHOG (ORCPT ); Thu, 15 Aug 2019 03:14:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:45972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730434AbfHOHOG (ORCPT ); Thu, 15 Aug 2019 03:14:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6ABAB20656; Thu, 15 Aug 2019 07:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565853244; bh=WtivyFKRGxuuhoSsg/tkmBPj16Bi9q7VKN8kdDZDkCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lu3qds97d3Cb4Y6h1uMZ5kdn13shzHpgSAMj2uMubJpM2OpFwznRoKX+A7txqKVw3 Ci1HzNz8kSa+IWCQ5/Y7yL5K2BjEY75Cyu3gJvKn+Pv1l8lyGdzVgzSBm3oINXqmOa /jGyTuTkzIjaYE6LW043xuWhnV6sczmCfkqohx8w= Date: Thu, 15 Aug 2019 09:14:02 +0200 From: Greg KH To: cy_huang Cc: Guenter Roeck , Heikki Krogerus , cy_huang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, shufan_lee@richtek.com Subject: Re: [PATCH] From: cy_huang Subject: usb: add more vendor defined ops in tcpci Message-ID: <20190815071402.GA25906@kroah.com> References: <1565842753-14245-1-git-send-email-u0084500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565842753-14245-1-git-send-email-u0084500@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 12:19:13PM +0800, cy_huang wrote: > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > index 303ebde..a6754fb 100644 > --- a/drivers/usb/typec/tcpm/tcpci.h > +++ b/drivers/usb/typec/tcpm/tcpci.h > @@ -130,6 +130,11 @@ struct tcpci_data { > bool enable); > int (*start_drp_toggling)(struct tcpci *tcpci, struct tcpci_data *data, > enum typec_cc_status cc); > + int (*set_vbus)(struct tcpci *tcpci, > + struct tcpci_data *data, bool source, bool sink); > + int (*get_current_limit)(struct tcpci *tcpci, struct tcpci_data *data); > + int (*set_current_limit)(struct tcpci *tcpci, > + struct tcpci_data *data, u32 max_ma, u32 mv); > }; You are adding callbacks here with no users of them, which isn't allowed. Please also submit the code that uses these callbacks at the same time so we can review it all together. thanks, greg k-h