linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4] perf diff: Report noisy for cycles diff
Date: Thu, 15 Aug 2019 15:22:36 +0200	[thread overview]
Message-ID: <20190815132236.GH30356@krava> (raw)
In-Reply-To: <20190813073037.3420-1-yao.jin@linux.intel.com>

On Tue, Aug 13, 2019 at 03:30:37PM +0800, Jin Yao wrote:

SNIP

>  static void
>  hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
>  {
> @@ -1662,6 +1794,10 @@ static void data__hpp_register(struct data__file *d, int idx)
>  		fmt->color = hpp__color_cycles;
>  		fmt->sort  = hist_entry__cmp_nop;
>  		break;
> +	case PERF_HPP_DIFF__CYCLES_HIST:
> +		fmt->color = hpp__color_cycles_hist;
> +		fmt->sort  = hist_entry__cmp_nop;
> +		break;
>  	default:
>  		fmt->sort  = hist_entry__cmp_nop;
>  		break;
> @@ -1688,8 +1824,15 @@ static int ui_init(void)
>  		 *   PERF_HPP_DIFF__RATIO
>  		 *   PERF_HPP_DIFF__WEIGHTED_DIFF
>  		 */
> -		data__hpp_register(d, i ? compute_2_hpp[compute] :
> -					  PERF_HPP_DIFF__BASELINE);
> +		if (cycles_hist && (compute == COMPUTE_CYCLES)) {
> +			data__hpp_register(d, i ? PERF_HPP_DIFF__CYCLES :
> +						  PERF_HPP_DIFF__BASELINE);
> +			data__hpp_register(d, i ? PERF_HPP_DIFF__CYCLES_HIST :
> +						  PERF_HPP_DIFF__BASELINE);
> +		} else {
> +			data__hpp_register(d, i ? compute_2_hpp[compute] :
> +						  PERF_HPP_DIFF__BASELINE);
> +		}

I tink that something like this might be less confusing instead of above:

                if (cycles_hist && i && (compute == COMPUTE_CYCLES)) 
                        data__hpp_register(d, PERF_HPP_DIFF__CYCLES);

other than that the patch looks ok to me

jirka

  reply	other threads:[~2019-08-15 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  7:30 [PATCH v4] perf diff: Report noisy for cycles diff Jin Yao
2019-08-15 13:22 ` Jiri Olsa [this message]
2019-08-16  1:22   ` Jin, Yao
2019-08-15 13:23 ` Jiri Olsa
2019-08-16  1:24   ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815132236.GH30356@krava \
    --to=jolsa@redhat.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).